Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Nav Buttons are always data-inline=TRUE in 1.4.3 change since 1.4.2 #7606

Closed
agador opened this issue Aug 3, 2014 · 5 comments
Closed

Nav Buttons are always data-inline=TRUE in 1.4.3 change since 1.4.2 #7606

agador opened this issue Aug 3, 2014 · 5 comments

Comments

@agador
Copy link

agador commented Aug 3, 2014

1.4.2. JS Fiddle: http://jsfiddle.net/jrbooth3/8r4Ty/

Buttons in NAV Bar in 1.4.2 default to full cell width. Can be "shortened" using data-inline=TRUE

1.4.3 JS Fiddle: http://jsfiddle.net/jrbooth3/LExhS/

Buttons in NAV Bar in 1.4.3 are always data-inline=TRUE. even specifying data-inline=FALSE has no effect.

Jim

1.4.2 output:
screen shot 2014-08-03 at 2 52 26 pm

1.4.3 output:

screen shot 2014-08-03 at 2 52 01 pm

@agador
Copy link
Author

agador commented Aug 4, 2014

Can be overridden by specifying style="width:100%;" in each tag in a NAVBAR that requires a full cell width button. Shouldn't this be the default action?

@jaspermdegroot
Copy link
Contributor

@agador

Thanks for reporting the issue. This is indeed a bug. It's a regression from 1ed6f92. Currently we say the framework makes all buttons inside toolbars default to inline and mini style (we are going to deprecate this behaviour in 1.5: #7574) and this commit was to solve an inconsistency. [edit: However, buttons in navbars shouldn't have been affected by this.] All our navbar examples only contain anchor elements, so this problem with button elements hasn't been noticed.

@jaspermdegroot
Copy link
Contributor

@arschmitz

I just noticed there are also issues with navbars with button elements when the navbar is not in a toolbar. In that case the buttons get shadow and corner style.
Is button elements in navbars something we don't support? I didn't see anything about it in the documentation. Although it's meant for navigation (links) I can imagine people want to use a navbar instead of a controlgroup because of it's full width style and grid.

@jaspermdegroot
Copy link
Contributor

We just discussed this during our meeting and we do want to support button elements in navbars so we are going to fix this.

@agador
Copy link
Author

agador commented Aug 8, 2014

Thanks for the updates.

Jim

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants