Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Build: Build script breaks "Classic theme" demo #7771

Closed
jaspermdegroot opened this issue Oct 10, 2014 · 7 comments
Closed

Build: Build script breaks "Classic theme" demo #7771

jaspermdegroot opened this issue Oct 10, 2014 · 7 comments
Assignees
Milestone

Comments

@jaspermdegroot
Copy link
Contributor

See jquery/demos.jquerymobile.com#4 (comment)

The problem is that our build script changes <link rel="stylesheet" href="../../css/structure/jquery.mobile.structure.css"> to <link rel="stylesheet" href="../css/themes/default/jquery.mobile-1.4.4.structure.min.css">.

@imaffett
Copy link

@jaspermdegroot - I'm not too familiar with the build script, but I see in processDemos and demos.backbone it's doing the following

processedName = grunt.config.process( name + "<%= versionSuffix %>" );

I think those should just be the following. Happy to submit a PR with the fix.

processedName = name;

@jaspermdegroot
Copy link
Contributor Author

@imaffett

Thanks for your offer to contribute! I am not too familiar with the build script either, but I think the problem is more this part of the script: https://github.com/jquery/jquery-mobile/blob/1.4-stable/Gruntfile.js#L147
@gseguin can you chime in here?

@imaffett
Copy link

@jaspermdegroot - What about the script tag above? Should that have the version in it or not?

https://github.com/jquery/jquery-mobile/blob/1.4-stable/Gruntfile.js#L105
https://github.com/jquery/jquery-mobile/blob/1.4-stable/Gruntfile.js#L109

If that's the case, then the regex can be changed to just use name instead of processedName

@gabrielschulhof
Copy link

@jaspermdegroot spotted it. We shouldn't be using processedName in the concatenation, but grunt.config.process( name + ".structure" + "<?= versionSuffix %>" )

@gabrielschulhof
Copy link

@arschmitz, @gseguin should we maybe add a travis job that runs casper on a versioned copy of dist/. I mean, like, running casper on the demos produced by grunt release:init dist?

@arschmitz
Copy link
Contributor

@gabrielschulhof hmm the only thing about that is it takes quite a while to run the casper tests. I will be updating the casper tests shortly to use grunt-spider which allows much better configuration for multiple test runs we can figure something out for testing this then as well. But lets not let that hold up fixing this.

@gabrielschulhof
Copy link

@arschmitz Yeah, that's cool. In fact, we should separate out the casper tests. Running them with every job is kinda superfluous, unless we key in the jQuery version into the casper tests as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants