Build: Build script breaks "Classic theme" demo #7771
Comments
@jaspermdegroot - I'm not too familiar with the build script, but I see in processDemos and demos.backbone it's doing the following
I think those should just be the following. Happy to submit a PR with the fix.
|
Thanks for your offer to contribute! I am not too familiar with the build script either, but I think the problem is more this part of the script: https://github.com/jquery/jquery-mobile/blob/1.4-stable/Gruntfile.js#L147 |
@jaspermdegroot - What about the script tag above? Should that have the version in it or not? https://github.com/jquery/jquery-mobile/blob/1.4-stable/Gruntfile.js#L105 If that's the case, then the regex can be changed to just use name instead of processedName |
@jaspermdegroot spotted it. We shouldn't be using |
@arschmitz, @gseguin should we maybe add a travis job that runs casper on a versioned copy of dist/. I mean, like, running casper on the demos produced by |
@gabrielschulhof hmm the only thing about that is it takes quite a while to run the casper tests. I will be updating the casper tests shortly to use grunt-spider which allows much better configuration for multiple test runs we can figure something out for testing this then as well. But lets not let that hold up fixing this. |
@arschmitz Yeah, that's cool. In fact, we should separate out the casper tests. Running them with every job is kinda superfluous, unless we key in the jQuery version into the casper tests as well. |
See jquery/demos.jquerymobile.com#4 (comment)
The problem is that our build script changes
<link rel="stylesheet" href="../../css/structure/jquery.mobile.structure.css">
to<link rel="stylesheet" href="../css/themes/default/jquery.mobile-1.4.4.structure.min.css">
.The text was updated successfully, but these errors were encountered: