Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Dialog: Cleanup style properties on _destroy. Reenables style check i…
…n domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers.
- Loading branch information
1 parent
8b15aaf
commit d687a1b
Showing
3 changed files
with
9 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d687a1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This highlighted two issues that were fixed in 53b940f and b9068c1
d687a1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that this is a legitimate check. We want to verify that the all styles are the same, not that the style attribute hasn't changed. @mikesherov @gnarf37 Isn't all the code that got deleted necessary to actually compare styles?
d687a1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old code checked computed styles, the new code checks the style attribute, which is a completely different thing. This is not a legitimate check.
d687a1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in 050e71b. I'll re-implement with the proper style checks.
d687a1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we care for computed styles. What's wrong with just checking the style attribute?
d687a1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what's wrong: http://jsfiddle.net/vry3v/
d687a1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not getting it. jQuery UI adds stuff to the style attribute, so it should remove that stuff. Why does it matter that the computed style doesn't necessarily match that?
d687a1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because computed styles are what users care about.