Commit
…. Fixes #6298.
- Loading branch information
There are no files selected for viewing
7 comments
on commit 873c284
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit causes the error:
Problem at line 5890 character 17: 'e' is already defined.
During the JSLint check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that too. Isn't JSLint wrong on this? The catch creates its own scope for the error arg according to ECMA-262 section 10.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that @dmethvin is right. Even if the 'e' exists so will catch replace it to a exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The catch creates its own scope for the error arg according to ECMA-262 section 10.2
An ES spec reference? That's borderline c.l.j. talk. Who cares about learning JavaScript give me my jQuery :P </sarcasm>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually trust Crockford over the ES spec. But I have to ask... does it make any difference whatsoever in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryantenney, if two men say they're Jesus, one of them must be wrong. :) Since it's hard to know which is the false idol, John appeased Crockford here: http://github.com/jquery/jquery/commit/da597bcf9014b1827e50c0e8f3b9268318574572
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmethvin lolwut!?
See my comment below - this is the line in question