Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple scrollable image gallery demo - fading not working properly #1080

Open
CipicReborn opened this issue Jul 8, 2014 · 1 comment
Open

Comments

@CipicReborn
Copy link

Hi there,

In the "scrollable" demos, the 4.3 "A simple scrollable image gallery" (http://jquerytools.org/demos/scrollable/gallery.html), the js code may deliver a better visual rendering if slightly changed.

The current code proposes a fading to transition between the gallery images. The problem is that the fading is done AFTER the loading of the new image (old image > new image > fading to transparent > back to normal visibility).

To get the proper behaviour (old image > fade to transparent > new image > back to normal visibility) ; the instruction "img.src = url;" should be transferred as third argument of the function fadeTo(), in order to be applied only after the fading to transparent.

@alibby251
Copy link
Contributor

Hi CipicReborn,

I've tried this in the JS code within this demo, but get an awful effect - it is making the images flicker badly! Can you please clarify where you tried this, so I can be sure I am replicating the change in the correct location?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants