Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot read property 'msie' of undefined #1113

Open
davidt22 opened this issue Oct 18, 2016 · 5 comments
Open

Uncaught TypeError: Cannot read property 'msie' of undefined #1113

davidt22 opened this issue Oct 18, 2016 · 5 comments

Comments

@davidt22
Copy link

When I try to load the library for load the tools, the browser shows me this error.

I think you are trying to get a property that is not defined, and you must secure it by doing a previous check.

@alexlibby
Copy link

Hi davidt22,

Can you please post the link you are using to load Tools, and the version of jQuery you are using?

@davidt22
Copy link
Author

jquery v3.1.0, and tools http://cdn.jquerytools.org/1.2.6/full/jquery.tools.min.js. When I try to use the overlay tool, i see that error in the console. Thanks.

@alexlibby
Copy link

Hi davidt22,

I'm pretty sure I know where the problem is:

The reason for asking for both links is that some versions of jQuery Tools come with jQuery bundled in by default; this is signified by the /full/ in the URL you've given. This means you don't technically need the second version of jQuery; you will effectively be loading two versions, which isn't good practice. If you change the /full/ to /all/, then this will drop the bundled version of jQuery.

However, this is only part of the problem - I think the cause of the issue you have is that Overlay used the browser.msie method to detect for the presence of certain versions of IE. This was deprecated in more recent versions of jQuery, and therefore is not supported with jQuery 3.1.0. It is easy to update though - if you do a search for browser.msie in the Issues part of this repo, then you will see a number of similar issues. You will need the uncompressed version though to do a proper replacement though..!

Give this a try - see how you get on...

@davidt22
Copy link
Author

Thank you for your reply. I will try it and let you a feedback about this issue in some days.

@tzvio
Copy link

tzvio commented Oct 20, 2017

Hi, i got this issue too, using jquery 2.2.4
i need to use both the new version of jquery and jquery tools
is it possible that i'll commit a fix to this repository?
@alexlibby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants