Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanoramaInfo msg can have image height and width? #2752

Open
knorth55 opened this issue Dec 7, 2022 · 5 comments
Open

PanoramaInfo msg can have image height and width? #2752

knorth55 opened this issue Dec 7, 2022 · 5 comments
Assignees

Comments

@knorth55
Copy link
Member

knorth55 commented Dec 7, 2022

rects_array_in_panorama_to_bounding_box_array node subscribe full panorama image,
but it uses only image height and image width image.

https://github.com/jsk-ros-pkg/jsk_recognition/blob/master/jsk_perception/node_scripts/rect_array_in_panorama_to_bounding_box_array.py#L53-L68

But when the network connection is low, it is hard to subscribe full panorama image.

We thought PanoramaInfo msg can have image height and image width information

@sktometometo what do you think?

cc. @AyumuIwa

@sktometometo
Copy link
Contributor

I didn't design PanoramaInfo without Image size since it is redundant, but it sounds good idea to put it in PanoramaInfo.

@knorth55
Copy link
Member Author

knorth55 commented Dec 7, 2022

Thank you, I will make a PR.
@sktometometo do you want to keep the current behavior and add new option?
or just rewrite to subscribe only panorama info?

@sktometometo
Copy link
Contributor

@knorth55 Let's make it simple. Please remove a subscriber of panorama image.

@knorth55
Copy link
Member Author

knorth55 commented Dec 7, 2022

@sktometometo OK, I will

@knorth55
Copy link
Member Author

knorth55 commented Dec 7, 2022

i made a PR #2753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants