You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, it's under the 9+ section of the mrjar. That's fine, but I wonder if we'd be better off getting modular-style Javadoc output, as we might if we moved it to the root? (Such output might either help or hurt people who are trying to link to us. Maybe it is part of the story with maxcellent/javadoc.io#182, but I haven't tried to understand that....)
The text was updated successfully, but these errors were encountered:
If the only reason to care is Javadoc, we might also be able to just run Javadoc differently.
My feeling has been that this isn't too important. But if it changes the URLs of our Javadoc output, then we might want to do it sooner rather than later (or decide to never do it, which may or may not be swimming upstream). Or we could insert our own redirects from the old locations to the new at any point.
I have discovered an extremely trivial reason to put module-info in the root: It makes --describe-module slightly easier to use (but kudos to it for the helpful error message!):
$ jar --describe-module --file j2objc-annotations-3.0.0.jar
releases: 9
No root module descriptor, specify --release
$ jar --describe-module --file j2objc-annotations-3.0.0.jar --release 9
releases: 9
com.google.j2objc.annotations@3.0.0 jar:file:///tmp/jobjc_release.SF8NzIp/j2objc/annotations/target/j2objc-annotations-3.0.0.jar/!META-INF/versions/9/module-info.class open
exports com.google.j2objc.annotations
requires java.base
Presumably the original command would Just Work if the module-info were in the root.
Anyway, I don't think that should have much effect on a decision here. I'm still not sure if either way is significantly better than the other.
Currently, it's under the 9+ section of the mrjar. That's fine, but I wonder if we'd be better off getting modular-style Javadoc output, as we might if we moved it to the root? (Such output might either help or hurt people who are trying to link to us. Maybe it is part of the story with maxcellent/javadoc.io#182, but I haven't tried to understand that....)
The text was updated successfully, but these errors were encountered: