Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No prompt in pyvenv.cfg makes venv incorrectly empty #373

Open
matthubb opened this issue Feb 8, 2023 · 1 comment · May be fixed by #387
Open

No prompt in pyvenv.cfg makes venv incorrectly empty #373

matthubb opened this issue Feb 8, 2023 · 1 comment · May be fixed by #387

Comments

@matthubb
Copy link

matthubb commented Feb 8, 2023

The new ini check will incorrectly blank out env if there is no prompt value in the ini file.

env = cfg.Section("").Key("prompt").String()

I'm not that familiar with golang, perhaps assigning the output of the ini lookup to a temporary value and checking it's not empty before overwriting env would suitably resolve this issue?

new_env = cfg.Section("").Key("prompt").String()
if new_env != "" {
        env = new_env
}
@elebertus elebertus linked a pull request Jun 27, 2023 that will close this issue
@elebertus
Copy link

#387 - this change resolved the issue for me. Waiting for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants