Merge pull request #13 from kavehmz/kaveh/checking_digit_contracts

checking digit contrcats
jy-deriv · May 3, 2017 · 5aab3f8 · 5aab3f8
2 parents d8920b2 + 9ddd53e
commit 5aab3f8
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/Changes b/Changes
@@ -2,6 +2,11 @@ Revision history for Finance-Contract
 
 {{$NEXT}}
 
+0.009     2017-05-03 01:54:55+00:00 UTC
+    Bug fixes:
+
+    * Support digit barriers correctly
+
 0.008     2017-05-02 06:22:04+00:00 UTC
     Bug fixes:
 

diff --git a/Makefile.PL b/Makefile.PL
@@ -40,7 +40,7 @@ my %WriteMakefileArgs = (
     "Test::CheckDeps" => "0.010",
     "Test::More" => "0.94"
   },
-  "VERSION" => "0.008",
+  "VERSION" => "0.009",
   "test" => {
     "TESTS" => "t/*.t"
   }

diff --git a/lib/Finance/Contract.pm b/lib/Finance/Contract.pm
@@ -3,7 +3,7 @@ package Finance::Contract;
 use strict;
 use warnings;
 
-our $VERSION = '0.008';
+our $VERSION = '0.009';
 
 =head1 NAME
 
@@ -775,7 +775,7 @@ sub _barrier_for_shortcode_string {
     return 'S' . roundnear(1, $string / $self->pip_size) . 'P' if $self->supplied_barrier_type eq 'difference';
 
     $string = $self->_pipsized_value($string);
-    if ($self->absolute_barrier_multiplier) {
+    if ($self->bet_type !~ /^DIGIT/ && $self->absolute_barrier_multiplier) {
         $string *= _FOREX_BARRIER_MULTIPLIER;
     } else {
         $string = floor($string);

diff --git a/t/for_shortcode_string.t b/t/for_shortcode_string.t
@@ -23,6 +23,11 @@ $params->{absolute_barrier_multiplier} = 1;
 $obj = new_ok( 'Finance::Contract', [$params] );
 cmp_ok $obj->_barrier_for_shortcode_string('0.12'),'eq', '120000', 'A absolute barrier will be multiplied in 1e6 if absolute_barrier_multiplier=1';
 
+$params->{bet_type} = 'DIGITMATCH';
+$obj = new_ok( 'Finance::Contract', [$params] );
+cmp_ok $obj->_barrier_for_shortcode_string('1'),'eq', '1',  'Even if absolute_barrier_multiplier is set there wont be any multiplication for ^DIGIT.*';
+
+$params->{bet_type} = 'test';
 $params->{supplied_barrier_type} = 'difference';
 $obj = new_ok( 'Finance::Contract', [$params] );
 cmp_ok $obj->_barrier_for_shortcode_string('+0.12'),'eq', 'S120P', 'A differnce barrier will manipulated to correct format depending on pipsize';
@@ -32,5 +37,3 @@ cmp_ok $obj->_barrier_for_shortcode_string('+0'),'eq', 'S0P', 'A differnce barri
 cmp_ok $obj->_barrier_for_shortcode_string('0'),'eq', 'S0P',  'A differnce barrier that is  0 will be  manipulated to correct format';
 
 done_testing;
-
-