Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with k3s-etcd informers not starting #10047

Merged
merged 1 commit into from
May 28, 2024

Conversation

brandond
Copy link
Member

Proposed Changes

Fix issue with k3s-etcd informers not starting

Start shared informer caches when k3s-etcd controller wins leader election. Previously, these were only started when the main k3s apiserver controller won an election. If the leaders ended up going to different nodes, some informers wouldn't be started

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner April 29, 2024 23:30
@brandond brandond force-pushed the fix-etcd-controller-informers branch 3 times, most recently from a77c3a9 to 6adc9ac Compare April 29, 2024 23:34
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 41.77%. Comparing base (5a0162d) to head (bb9166f).

Files Patch % Lines
pkg/etcd/etcd.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10047      +/-   ##
==========================================
- Coverage   41.81%   41.77%   -0.04%     
==========================================
  Files         173      173              
  Lines       14642    14644       +2     
==========================================
- Hits         6122     6117       -5     
- Misses       7355     7360       +5     
- Partials     1165     1167       +2     
Flag Coverage Δ
e2etests 36.36% <0.00%> (-0.05%) ⬇️
inttests 37.06% <0.00%> (+0.07%) ⬆️
unittests 11.39% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dereknola
dereknola previously approved these changes May 1, 2024
vitorsavian
vitorsavian previously approved these changes May 23, 2024
Start shared informer caches when k3s-etcd controller wins leader election. Previously, these were only started when the main k3s apiserver controller won an election. If the leaders ended up going to different nodes, some informers wouldn't be started

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond dismissed stale reviews from vitorsavian and dereknola via bb9166f May 23, 2024 21:23
@brandond brandond force-pushed the fix-etcd-controller-informers branch from 6adc9ac to bb9166f Compare May 23, 2024 21:23
@brandond brandond requested review from dereknola, vitorsavian and a team May 23, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants