-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix netpol crash when node remains tained uninitialized #10073
Conversation
d1c6cbc
to
3e3aeaa
Compare
3e3aeaa
to
a78c982
Compare
a78c982
to
de6e864
Compare
de6e864
to
eaf72c3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10073 +/- ##
==========================================
- Coverage 47.71% 41.80% -5.91%
==========================================
Files 173 173
Lines 14642 14642
==========================================
- Hits 6986 6121 -865
- Misses 6318 7356 +1038
+ Partials 1338 1165 -173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
It is concievable that users might take more than 60 seconds to deploy their own cloud-provider. Instead of exiting, we should wait forever, but with more logging to indicate what's being waited on. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
eaf72c3
to
c2feb45
Compare
Proposed Changes
Fix netpol crash when node remains tained unintialized
It is concievable that users might take more than 60 seconds to deploy their own cloud-provider. Instead of exiting, we should wait forever, but with more logging to indicate what's being waited on.
The current behavior was added in #9076
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments