Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netpol crash when node remains tained uninitialized #10073

Merged
merged 2 commits into from
May 29, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented May 6, 2024

Proposed Changes

Fix netpol crash when node remains tained unintialized

It is concievable that users might take more than 60 seconds to deploy their own cloud-provider. Instead of exiting, we should wait forever, but with more logging to indicate what's being waited on.

The current behavior was added in #9076

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner May 6, 2024 19:44
manuelbuil
manuelbuil previously approved these changes May 6, 2024
manuelbuil
manuelbuil previously approved these changes May 24, 2024
dereknola
dereknola previously approved these changes May 24, 2024
@brandond brandond dismissed stale reviews from dereknola and manuelbuil via eaf72c3 May 24, 2024 18:05
@brandond brandond requested review from dereknola, manuelbuil and a team May 24, 2024 18:36
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 41.80%. Comparing base (aa36341) to head (eaf72c3).
Report is 9 commits behind head on master.

Current head eaf72c3 differs from pull request most recent head c2feb45

Please upload reports for the commit c2feb45 to get more accurate results.

Files Patch % Lines
pkg/agent/netpol/netpol.go 25.00% 3 Missing ⚠️
pkg/etcd/metadata_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10073      +/-   ##
==========================================
- Coverage   47.71%   41.80%   -5.91%     
==========================================
  Files         173      173              
  Lines       14642    14642              
==========================================
- Hits         6986     6121     -865     
- Misses       6318     7356    +1038     
+ Partials     1338     1165     -173     
Flag Coverage Δ
e2etests 36.41% <20.00%> (-9.84%) ⬇️
inttests 37.00% <20.00%> (+17.19%) ⬆️
unittests 11.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
It is concievable that users might take more than 60 seconds to deploy their own cloud-provider. Instead of exiting, we should wait forever, but with more logging to indicate what's being waited on.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team May 28, 2024 22:56
@dereknola dereknola changed the title Fix netpol crash when node remains tained unintialized Fix netpol crash when node remains tained uninitialized Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants