Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch stargz over to cri registry config_path #9977

Merged
merged 1 commit into from
May 23, 2024

Conversation

brandond
Copy link
Member

Proposed Changes

Migrate the stargz CRI registry config over to config_path, same as the core containerd CRI config.

This should have been done as part of #8973 but I didn't realize stargz already supported it, ref: containerd/stargz-snapshotter#331

Types of Changes

tech debt

Verification

Note use of config_path under [plugins."io.containerd.snapshotter.v1.stargz".registry] in config.toml, when stargz snapshotter is enabled.

Testing

yes

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner April 19, 2024 00:22
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.53%. Comparing base (81cd630) to head (e07466e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9977      +/-   ##
==========================================
- Coverage   49.63%   43.53%   -6.10%     
==========================================
  Files         158      158              
  Lines       14017    14017              
==========================================
- Hits         6958     6103     -855     
- Misses       5755     6750     +995     
+ Partials     1304     1164     -140     
Flag Coverage Δ
e2etests 36.41% <ø> (-9.73%) ⬇️
inttests 37.06% <ø> (+<0.01%) ⬆️
unittests 16.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants