Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consumer.consuming.pause and consumer.consuming.retry are misleading #1671

Closed
mensfeld opened this issue Oct 16, 2023 · 1 comment
Closed

consumer.consuming.pause and consumer.consuming.retry are misleading #1671

mensfeld opened this issue Oct 16, 2023 · 1 comment
Assignees
@mensfeld
Labels
bug Bugs and issues instrumentation Things related to monitoring and instrumentation

Comments

@mensfeld
Copy link
Member

Both consumer.consuming.pause and consumer.consuming.retry can happen during the whole lifecycle of a consumer and not only during the consumption. Especially when filters are involved or other advanced options. This means that this naming should be aligned.

No integrations use it internally except web-ui but we still should make a notice about this change.
@mensfeld mensfeld self-assigned this Oct 16, 2023
@mensfeld mensfeld added the bug Bugs and issues label Oct 16, 2023
@mensfeld mensfeld transferred this issue from karafka/karafka-web Oct 16, 2023
@mensfeld mensfeld added the instrumentation Things related to monitoring and instrumentation label Oct 16, 2023
@mensfeld
Copy link
Member Author

Closing. There is client level pausing that is system wide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mensfeld mensfeld

Labels
bug Bugs and issues instrumentation Things related to monitoring and instrumentation
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mensfeld