Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite vimiv completely in Qt #61

Open
karlch opened this issue Dec 13, 2017 · 3 comments
Open

Rewrite vimiv completely in Qt #61

karlch opened this issue Dec 13, 2017 · 3 comments
Labels

Comments

@karlch
Copy link
Owner

karlch commented Dec 13, 2017

I have played around with PyQt5 lately and must say I was very happy.

Reasons for a complete rewrite:

  • The code is not very clean, lots of it could be done in a more elegant and extendable way
  • The tests are horrible
  • Gtk has bugged me quite a bit

Reasons against:

  • Lots of work
  • Destroys any packages, user configurations, ...

If anybody has an opinion on this, I would love to hear it.

@ninrod
Copy link

ninrod commented Feb 27, 2018

Hi! I'm interested in these bindings for gtk/qt for python.

What are the main advantages of Qt against GTK? Would pyqt allow vimiv to be used in windows? does pygtk already allow that?

@karlch
Copy link
Owner Author

karlch commented Mar 5, 2018

I can just give you a subjective list of things if noticed when comparing the two:

  • The python bindings for Qt feel much more native and much better compared to the gobject based wrapper for Gtk
  • Customizing Qt widgets was much easier for me
  • The Qt documentation is amazing, although Gtk's is pretty good too
  • I used to love the idea of styling the complete toolkit with themes (Gtk) but custom themes regularly break with new versions of Gtk

In your case I would just try both out and see how you like them/how easily you are able to learn them.

The windows support of Qt is a lot better than the one of Gtk. So in principle it should work already but with a lot of hassle. With Qt it should be easier to do. But I do not own a windows machine and do not plan to buy one, so I will not package/test for windows. Obviously if someone volunteers to do this, I will happily include the contribution.

Hope this helps a bit 😃

@karlch karlch mentioned this issue Mar 6, 2018
@karlch karlch mentioned this issue Dec 17, 2018
@karlch
Copy link
Owner Author

karlch commented Jan 8, 2019

The Qt port has been written and is now publicly available: https://github.com/karlch/vimiv-qt

I feel like the new code is much easier to maintain and therefore this will be the future of vimiv. It is not yet feature-complete, so this version will still see maintenance for relevant bugs, but new features will only be implemented in the Qt port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants