Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows color image ONLY on IE 10, 11 #71

Closed
musa-pro opened this issue Jun 2, 2017 · 2 comments
Closed

Shows color image ONLY on IE 10, 11 #71

musa-pro opened this issue Jun 2, 2017 · 2 comments

Comments

@musa-pro
Copy link

musa-pro commented Jun 2, 2017

I wonder why it doesn't work in IE10, 11 and throws following error

unable to get property 'join' of undefined or null reference
jquery.gray.min.js 3,1464

Btw, I'm using jquery 1.12.4
You can test it here http://bit.ly/2qJWPPl

@karlhorky
Copy link
Owner

karlhorky commented Jun 5, 2017

Hi @appskitchen, this is most likely because you have a version of Modernizr on the page already but the required feature detects are not included in your Modernizr build.

In #72 I'm going to make the Developer Experience (DX) a bit better. I've documented what to do with an existing Modernizr build and next in that pull request I will also make gray throw an error when the required feature detects are not included.

Edit: Error handling done in af51457

@karlhorky
Copy link
Owner

These two improvements have been deployed with v1.6.0:

  • document how to use library with existing Modernizr
  • throw error with Modernizr build that doesn't include necessary feature detects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants