Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better information when a file is changed #23

Open
karun012 opened this issue Apr 2, 2015 · 4 comments
Open

Better information when a file is changed #23

karun012 opened this issue Apr 2, 2015 · 4 comments

Comments

@karun012
Copy link
Owner

karun012 commented Apr 2, 2015

Right now when a file is changed Arion just says -

/foo/bar/baz.hs changed

I think it should show the user more information like what tests are associated with the file, and also the module name instead of the absolute path.

Module Baz changed

Baz is associated with these tests
BazSpec
FooSpec
BarSpec

...
@mwotton
Copy link
Collaborator

mwotton commented Apr 3, 2015

Hm. Isn't this just noise? Won't you see the tests themselves running?

@karun012
Copy link
Owner Author

karun012 commented Apr 3, 2015

I feel it's hard to say which tests actually ran. I don't know. Maybe it is
a little noisy.
On Apr 2, 2015 5:38 PM, "Mark Wotton" notifications@github.com wrote:

Hm. Isn't this just noise? Won't you see the tests themselves running?


Reply to this email directly or view it on GitHub
#23 (comment).

@mwotton
Copy link
Collaborator

mwotton commented Apr 3, 2015

Yeah. Hm. Well, I guess from my zen-mode goals I shouldn't actually have to
know what's going to run - I just want the right stuff to happen :) Perhaps
the time to notify is actually when you are running the test, rather than
at the top? you're going to scroll to the failing test anyway.

On Fri, Apr 3, 2015 at 7:39 AM Karun notifications@github.com wrote:

I feel it's hard to say which tests actually ran. I don't know. Maybe it is
a little noisy.
On Apr 2, 2015 5:38 PM, "Mark Wotton" notifications@github.com wrote:

Hm. Isn't this just noise? Won't you see the tests themselves running?


Reply to this email directly or view it on GitHub
#23 (comment).


Reply to this email directly or view it on GitHub
#23 (comment).

@karun012
Copy link
Owner Author

karun012 commented Apr 3, 2015

Yeah. Now that you mention zen-mode I think we should roll this back. We'll see how zen-mode goes and decide if we want to put this back or not :)

@karun012 karun012 removed this from the v0.1.0.9 milestone Apr 3, 2015
karun012 added a commit that referenced this issue Apr 3, 2015
we will get back to this once zen-mode is implemented

This reverts commit 86f019b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants