test runner - separate diagnostics

[KFlash]

All diagnostics in test runner is seen as an error. Need to separate this.

If 'DiagnosticKind' === 16 should trigger error diagnostics.

If the value is '64' should for example output

Lint
----

Everything is okay

if the value is '8' should output an warning:

Warning
----

'eval' can be unsafe here

[KFlash]

@aladdin-add the linter diagnostics is not an error so should not prevent printing. I tested this now and the linter diagnostics blocking printing.

As seen in this picture everything is generated as an error.

I'm using my own reporter for this.

[KFlash]

Linting and error seen together

[aladdin-add]

but IMHO better not to mix the linting errors to the diagnostics. linting should be another public API?

[KFlash]

All diagnostics are just numbers. It's up to end users how to deal with them.

What do you mean with 'linting should be another public API?'

[aladdin-add]

#88 (comment)

[aladdin-add]

just my two cents. I can adjust the tests if you prefer the one API for all the things. :)

[KFlash]

I prefer not to kill performance and many "rules" in e. g. ESLint is parser errors.

The diagnostics is just diagnostics and does everything in one go instead of walk the tree, consume memory and kill performance twice.

This is best seen in an Editor where you can separate the diagnostics, and when it comes to public API. There are no problem to add a kataw.lint() and in the CLI use the reporter to only show diagnostics for linting and ignore all errors. Then it's equal to ESLint

Here is an "eslint look a like" example

[KFlash]

@aladdin-add friendly ping