Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple passwords presented despite only one matching URL #2164

Open
vbeffa opened this issue Mar 30, 2024 · 10 comments
Open

Multiple passwords presented despite only one matching URL #2164

vbeffa opened this issue Mar 30, 2024 · 10 comments
Labels

Comments

@vbeffa
Copy link

vbeffa commented Mar 30, 2024

I have two passwords set up for my ASUS router. For one the URL is http://192.168.1.1/Main_Login.asp. For the other the URL is http://192.168.1.1/Advanced_OpenVPNClient_Content.asp. On http://192.168.1.1/Advanced_OpenVPNClient_Content.asp, the second password is correctly auto-filled. On http://192.168.1.1/Main_Login.asp, both passwords are presented, and neither is auto-filled.

Expected Behavior

Only one password is presented and auto-filled on http://192.168.1.1/Main_Login.asp.

Current Behavior

Two passwords are presented on http://192.168.1.1/Main_Login.asp.

Steps to Reproduce (for bugs)

  1. Create router passwords as described above.
  2. Navigate to the URLs above.

Debug info

KeePassXC - 2.7.7
KeePassXC-Browser - 1.9.0.2
Operating system: Mac
Browser: Firefox

@varjolintu
Copy link
Member

This is expected, because at this point only the domain (here's the IP address) only matters if no paths are used.

@vbeffa
Copy link
Author

vbeffa commented Mar 30, 2024

Sorry I don't follow - both URLs use a path, and the second one (http://192.168.1.1/Advanced_OpenVPNClient_Content.asp) correctly auto-fills the username and password.

@varjolintu
Copy link
Member

That entry URL will match everything under http://192.168.1.1/*. If you use paths in the URL and in your local server, the matching will work correctly. Meaning https://192.168.1.1/path will not be matched with https://192.168.1.1/secondpath.

@vbeffa
Copy link
Author

vbeffa commented Mar 30, 2024

I'm still not following. I'm using paths in the URLs and my browser:

  • http://192.168.1.1/Main_Login.asp - path is /Main_Login.asp
  • http://192.168.1.1/Advanced_OpenVPNClient_Content.asp - path is /Advanced_OpenVPNClient_Content.asp

For both, I use the full path in the password entry (NOT just http://192.168.1.1) and when I navigate to the pages in my browser. The first entry does not auto-fill on the login page but the second does on the OpenVPN page.

@varjolintu
Copy link
Member

What I mean there's a difference between:
http://192.168.1.1/main/Main_Login.asp and http://192.168.1.1/anotherAdvanced_OpenVPNClient_Content.asp

But if you serve both files under http://192.168.1.1 there's no difference and both entries are returned.
Defining an exact URL is done here for KeePassXC 2.8.0: keepassxreboot/keepassxc#9835

@vbeffa
Copy link
Author

vbeffa commented Mar 30, 2024

Are you referring to having a folder between the domain and the file? Again, how does that explain why the second URL auto-fills correctly? The PR you linked is in draft state - what am I supposed to do with it?

@varjolintu
Copy link
Member

Are you using http://192.168.1.1 as your entry URL?

The PR I linked just addresses an issue about exact URL's, if you want certain entries to specify them.

@vbeffa
Copy link
Author

vbeffa commented Mar 30, 2024

No, I'm using the full paths as I stated. (Unfortunately KeePass seems to somehow be blocking me from taking screenshots of it. Apparently I'm not intelligent enough to not take an image of my password and only the URL, so Keepass needs to block me from all screenshots. I don't see a setting to disable this, so I'm unable to show the URLs other than as stated in my earlier comments.) The PR is not merged, so whatever changes it is making are not available in the downloaded version I am using, so what changes should I make in my entries?

@varjolintu
Copy link
Member

Ok, I understand. I'll take a look at the issue and try to reproduce it meyself.

@vbeffa
Copy link
Author

vbeffa commented Mar 30, 2024 via email

@varjolintu varjolintu added the bug label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants