Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write protection option in eject menu doesn't persist #516

Open
arithesage opened this issue Aug 1, 2021 · 4 comments
Open

Write protection option in eject menu doesn't persist #516

arithesage opened this issue Aug 1, 2021 · 4 comments

Comments

@arithesage
Copy link

Hi!

I'm using Flash Floppy v3.21 and have my config set to respect the FAT read-only attribute instead of forcing it on.
I have enabled read-only in all my ADFs and they shows "Write protection" option in Eject menu correctly enabled

The problem comes when i decide to change the option from the Eject menu.

I have followed these steps:

  1. Inserting an ADF.
  2. Pushing encoder to enter Eject menu.
  3. Navigating to "Write protection" option, that is correctly enabled.
  4. Pushing the encoder to change "Write protection" from ON to OFF.
  5. Navigating to "Eject menu" option.
  6. Pushing encoder to go back to the ADF list.
  7. Pushing the encoder again to enter the "Eject menu".
  8. Navigating again to the "Write protection" option, that remains in OFF.
  9. Repeating steps 5 and 6.
  10. Selecting another ADF and inserting it.
  11. Selecting the previously inserted ADF and inserting it again.
  12. Entering the "Eject menu".
  13. Navigating to the "Write protection" option.

The option is again ON, as it was at the beginning.

So, it seems to me that the read-only flag isn't saved correctly when changed from Flash Floppy menu...

Thanks for your assistance!

@keirf
Copy link
Owner

keirf commented Aug 2, 2021

You are correct it is a soft setting which does not get saved to the usb drive. I never thought about doing that. Perhaps it makes more sense.

@keirf keirf changed the title Write protection option in eject menu don't work Write protection option in eject menu doesn't persist Jun 22, 2022
@avelor-76
Copy link

Indeed, the current behavior might be confusing. I spent some time trying to understand why the write protection "disappeared", e.g. thought there's something wrong with my USB stick ;-)
Reading this issue I then understood that's normal behavior.

Maybe, if you don't want to change read-only attributes on the USB drive, it could make more sense to call the option "temporary write protection", or something like that...

@arithesage
Copy link
Author

I case changing the ADFs attributes isn't possible or desirable, maybe we can create a file like "Game.adf.rw" as a workaround to keep track of the read-only status?

@keirf
Copy link
Owner

keirf commented Jun 7, 2023

Persisting the change in FAT attributes is I think doable. I wonder whether it is better than the current behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants