[Enhancement]: Change data.mask convention in Stages 3+

[taylorbell57]

Instrument

Other (any stage)

What is your suggestion?

At present, the Stage 3 code sets data.mask to True where there is good data and data.mask to False where the data is bad. This is the opposite convention of numpy masked arrays and is confusing to understand if you send someone your FluxData.h5 file (since most people, including myself) are likely to assume that a point should be masked if data.mask is True. The current convention was moderately convenient at one point since doing flux*mask zeroes out pixels that shouldn't be used, but I'm pretty sure we're using numpy masked arrays throughout now.

Code of Conduct

• I agree to follow this project's Code of Conduct

[kevin218]

We will need to thoroughly test any changes that address this enhancement. There are many places in the code were we could introduce a bug by not accounting for this switch.