Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use browser router for Account Console #27442

Closed
jonkoops opened this issue Mar 1, 2024 · 0 comments · Fixed by #22192
Closed

Use browser router for Account Console #27442

jonkoops opened this issue Mar 1, 2024 · 0 comments · Fixed by #22192

Comments

@jonkoops
Copy link
Contributor

jonkoops commented Mar 1, 2024

The router for the Account Console uses the hash based router, but should be changed to the browser based one, which is the recommended router for React Router projects. This will allow the usage of real paths for URLs rather than 'fake' paths that use a hash (#).

The main motivation, aside from the React Router recommendation, is that this will allow us to use the same paths for local development, as well as in production. This reduces the surface for bugs, and also makes easier to do end-to-end testing without adding exceptions.

@jonkoops jonkoops added kind/task kind/enhancement Categorizes a PR related to an enhancement area/account/ui and removed kind/task labels Mar 1, 2024
@jonkoops jonkoops self-assigned this Mar 1, 2024
jonkoops added a commit that referenced this issue Mar 4, 2024
Closes #27442

Signed-off-by: Jon Koops <jonkoops@gmail.com>
ahus1 pushed a commit to ahus1/keycloak that referenced this issue Mar 22, 2024
Closes keycloak#27442

Signed-off-by: Jon Koops <jonkoops@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant