Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript types to reflect examples. #169

Open
jckw opened this issue Aug 28, 2019 · 1 comment
Open

Update TypeScript types to reflect examples. #169

jckw opened this issue Aug 28, 2019 · 1 comment

Comments

@jckw
Copy link

jckw commented Aug 28, 2019

The current declaration file specifies doesn't specify any props as optional, although most actually are. This makes the package difficult to use in TypeScript projects without lots of @ts-ignores.

The examples in the README also make it clear that most props aren't required. If I can get some guidance on what is optional, I'll happily make the changes and put together a PR.


Alternatively, the typings could be moved to the DefinitelyTyped repo.

@AmitDigga
Copy link

Its really hard to work with incorrectly typed package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants