Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive assertion in Cypress test related to Istio config validation #7237

Open
matejnesuta opened this issue Mar 28, 2024 · 2 comments · May be fixed by #7269
Open

False positive assertion in Cypress test related to Istio config validation #7237

matejnesuta opened this issue Mar 28, 2024 · 2 comments · May be fixed by #7269
Assignees
@matejnesuta
Labels
bug Something isn't working

Comments

@matejnesuta
Copy link
Contributor

Describe the bug

kiali/frontend/cypress/integration/common/istio_config.ts

Line 522 in d0b8a33

Then(

This specific command passes even though the health of the object is different then asserted. This command is also used in multiple tests.

image
@matejnesuta matejnesuta added the bug Something isn't working label Mar 28, 2024
@matejnesuta matejnesuta self-assigned this Mar 28, 2024
@matejnesuta
Copy link
Contributor Author

I tried to reproduce the issue today, but no luck

@matejnesuta
Copy link
Contributor Author

I am not sure why, but on some occasions, the assertion completely skips the inner block of code starting at line 526 and passes even though it should not pass.

@matejnesuta matejnesuta linked a pull request Apr 10, 2024 that will close this issue
Open
@matejnesuta matejnesuta linked a pull request Apr 10, 2024 that will close this issue
Flaky assertion fix #7269
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejnesuta matejnesuta

Labels
bug Something isn't working
Projects
Kiali Sprint 24-6 | Kiali 1.85
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flaky assertion fix matejnesuta/kiali
1 participant
@matejnesuta