Allow flexibility of from_address and send_statuses

[aaronblythe]

I have a need to post just failures to a message board that is selective of who can post.

mail_handler = MailHandler.new({:to_address => "message-board@example.com",
                                 :from_address => "trusted-svc-acct@example.com",
                                 :send_statuses => ["Failed"]})

This slight modification is passive and allows the flexibility to meet these needs.

[trobrock]

👍

[kisoku]

what does this offer that setting a separate exception handler in your chef config doesn't ?

[trobrock]

This offers the ability to only send email on failures, unless I am missing that configuration option.

[aaronblythe]

This change is passive and should not break existing users of this gem. It provides the ability to make more use of pony by allowing the from_address to be configurable. It also provides the ability flex only to only email on failures or successes or both. For early development I like the ability to get both successes and failures, however for my more established code our community only needs to know about failures.

The chef documentation points to this gem as the Community Based Email Handler: http://wiki.opscode.com/display/chef/Exception+and+Report+Handlers So I thought that providing a pull request was the recommended mechanism to contribute. Forgive me if I am misunderstanding, are you suggesting that I "roll my own"? If I were to do that I would have to fork this change the name and host in my own private gem repo. I am not opposed to this, it just doesn't seem that community-like.

[trobrock]

@aaronblythe I have forked this gem to https://github.com/trobrock/chef-handler-mail and the chef-mail gem if you would like to move your PR there.

[aaronblythe]

@trobrock Will do. However it looks like https://github.com/drax68/chef-handler-mail is connected to https://rubygems.org/gems/chef-handler-mail-extended should we move there? What I am most concerned about is contributing to something I can access at rubygems.org. I am maintaining a fork within my company's gem repo at this point.

[trobrock]

I created the chef-mail gem on rubygems that is based off my fork
On Feb 17, 2013 8:20 PM, "Aaron Blythe" notifications@github.com wrote:

@trobrock https://github.com/trobrock Will do. However it looks like
https://github.com/drax68/chef-handler-mail is connected to
https://rubygems.org/gems/chef-handler-mail-extended should we move
there? What I am most concerned about is contributing to something I can
access at rubygems.org. I am maintaining a fork within my company's gem
repo at this point.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-13706001.