@veloman-yunkan is the expected behavior for the reading list to stay attached to the tab in which it was opened from, until closed by the user?
e.g.

• Open tab x
• From tab x, open the reading list
• Open an item from the reading list (by default to a new tab y)
• Returning to tab x the reading list is still open or closed?

Please discard my last comment.

You want the behavior to be that:

• The reading list selected item is opened in the current tab
• The reading list should stay open if the user navigates to a different tab and back to the one that he opened the list in

Correct?

Here is the only visual input we have as guidance:

Here my remarks:

• We can see the quite high visual difference between what we have and the goal!
• The reading list side should not conceptually or from a user perspective depend from a tab
• It should be kept open whatever what we do with tabs
• Opening a bookmark should open in current tab or in a new tab if double-click (mouse middle-click)
• Regarding handling around library tab: I would just hide the sidebar when displaying library tab and display it otherwise.

@kelson42 I have made a PR implementing the pinning of the reading list.

Regarding your 4th point

Opening a bookmark should open in current tab or in a new tab if double-click (mouse middle-click)

For me at least, on the current implementation, when single or middle clicking on a reading list element, nothing happens. The only thing that works is double clicking, where the element is opened in a new tab. Do we want to change this?

Opening a bookmark should open in current tab or in a new tab if double-click (mouse middle-click)

For me at least, on the current implementation, when single or middle clicking on a reading list element, nothing happens. The only thing that works is double clicking, where the element is opened in a new tab. Do we want to change this?

Indeed:

• Simple click should open in current tab
• Double-click AND middle-mouse-clikc should open in new tab

• Regarding handling around library tab: I would just hide the sidebar when displaying library tab and display it otherwise.

@kelson42 What's the problem with displaying the reading list alongside the library tab?

@veloman-yunkan essentially the side panel of the library tab and the reading list is the same element with different contents, so despite cluttering I think it would be weird to implement

@sgourdas I thought so too when I was about to raise my concern, but I checked and it seems that it's not the case:

@sgourdas I thought so too when I was about to raise my concern, but I checked and it seems that it's not the case:

kiwix-desktop/ui/mainwindow.ui

Lines 70 to 78 in 0172184

	<widget class="ContentManagerSide" name="contentmanagerside">
	<property name="sizePolicy">
	<sizepolicy hsizetype="Fixed" vsizetype="Preferred">
	<horstretch>0</horstretch>
	<verstretch>0</verstretch>
	</sizepolicy>
	</property>
	</widget>
	<widget class="ReadingListBar" name="readinglistbar"/>

Ok, now I see why I was wrong.

$ grep -w sideBar src/mainwindow.cpp 
    mp_ui->sideBar->setCurrentWidget(mp_ui->contentmanagerside);
        mp_ui->sideBar->setCurrentWidget(mp_ui->readinglistbar);
        mp_ui->sideBar->show();
        mp_ui->sideBar->hide();
        mp_ui->sideBar->setCurrentWidget(mp_ui->contentmanagerside);
        mp_ui->sideBar->show();
        mp_ui->sideBar->hide();

Yes, both elements are loaded on the sideBar so I am not sure how we would get around that in a simple way

They can simply be displayed side by side rather than in a stacked widget. @kelson42 What do you think about it?

@veloman-yunkan @sgourdas Does this PR needs a new review?

@kelson42 Review done