Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knockout throws an error if it finds an unmatched closing virtual element (<!--/ko-->). This feature breaks old HTML pages in our system. #2582

Open
AlexMelw opened this issue Dec 16, 2021 · 2 comments
Labels
Milestone

Comments

@AlexMelw
Copy link

AlexMelw commented Dec 16, 2021

Hi,
taking into account the Knockout 3.5.0 has been released changing its minor number of semver, it shouldn't break old code.
Yet we have old HTML pages which have unmatched <-- /ko --> tags.
The code starting crashing as KO throws an error.

For some reasons we are not able to update the code of the old HTML pages.
How could we disable that feature in order to keep compatibility with old pages?

image

CC @mbest

@mbest mbest added this to the 3.5.2 milestone Mar 8, 2023
@mbest mbest added the breaking label Mar 8, 2023
@mbest
Copy link
Member

mbest commented Mar 8, 2023

Perhaps we should only output this as an error in debug mode.

@kanoshin
Copy link

@mbest hey, thanks for working on supporting the Knockout. Would you happen to have any updates about the 3.5.2 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants