Add element access via at() to std::mdspan
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanlachnit
changed the title
at() to std::mdspan
mhoemmen
reviewed
Nov 30, 2023
Signed-off-by: Stephan Lachnit <stephanlachnit@debian.org>
stephanlachnit
force-pushed
the
p-add-mdspan-at
branch
from
9e59d6e
to
7b3a6e0
Compare
|
Given that SizeTypes can be signed, it should also check for indices[r] < 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #300
Possible implementation for ::at element access to mdspan with boundary checks. The boundary check is implemented with a for loop, as I did not see any other way to achieve this. The error message is inspired by the
std::span::aterror message from libstdc++ (gcc-mirror/gcc@1fa85dc).Note that this does not implement ::at element access to mdarray.