Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import should detect/warn on duplicate titles #2

Open
krid opened this issue Apr 23, 2010 · 2 comments
Open

Import should detect/warn on duplicate titles #2

krid opened this issue Apr 23, 2010 · 2 comments
Labels

Comments

@krid
Copy link
Owner

krid commented Apr 23, 2010

Importer now silently ignores duplicates, which is definitely wrong.

What should it do?

*) Throw an error and refuse to import anything?

*) Skip the second occurrence, and report the titles of skipped records?

*) Automatically append a string to disambiguate (dot one, dot two, etc.)?

We could offer the option to choose from the above, but that's probably overkill, and in any case we still have to decide which is the default behavior.

@maverickmatt
Copy link
Collaborator

The second option is what the command line importer for codewallet, etc were doing (in the midst of the other verbose logging, so it may not have been obvious). Thinking about it a little more, given the fact that the titles are duplicates, it would probably be good to print out more information, perhaps everything but the password and notes?

@maverickmatt
Copy link
Collaborator

I did consider the first option also, though I thought it might be a bit extreme -- though it would certainly force the user to address them (which depending on their skill level, might just lead to more problems). The third option is friendly, but given the fact that users generally blow through messages without reading them very closely, they might not ever realize it. Granted, that is still an issue for the second option, so regardless, it probably needs to be pretty "in your face" to make sure they see it. Perhaps these auto-renamed records could be flagged in a way the user could easily locate and address them (tag them with .one-DUPLICATE, etc)?

One problem with prompting the user for an action is then it requires additional work to use the same code in batch and interactive mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants