Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bugs on Win10 - v0.1.1 #10

Open
ClausEspersen opened this issue Feb 20, 2021 · 8 comments
Open

Various bugs on Win10 - v0.1.1 #10

ClausEspersen opened this issue Feb 20, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@ClausEspersen
Copy link

  1. Account balance area is just blank. No image, no value.
  2. View menu - Toogle Full Screen, just place window in top left corner. Remove if fullscreen is not supposed to be supported.
  3. Turtlecoin icon observed used as taskbar icon.
  4. Export to csv does not produce a file output.
  • Version used : v0.1.1
  • Operating System and version : Win10
@ClausEspersen ClausEspersen added the bug Something isn't working label Feb 20, 2021
@f-r00t
Copy link
Member

f-r00t commented Feb 20, 2021

Thanks for the heads up. We will look into it.

@Shai0Hulud
Copy link

I have to confirm the first two points.

It would be nice if the problem, which from my point of view is easy to fix (resizable window), but has obviously existed since February, could be resolved.

image

@f-r00t
Copy link
Member

f-r00t commented May 9, 2021

It would be nice if the problem, which from my point of view is easy to fix (resizable window), but has obviously existed since February, could be resolved.

Are you referring to the full screen issue, or the missing balance view? Care to explain why full re-sizable windows would solve the balance bar issue?

The problem for us that we have yet to be able to reproduce the issue with the missing balance bar, making it hard to fix.

If someone who is experiencing the issue could download and run the repo in dev mode with:

git clone https://github.com/kryptokrona/kryptokrona-desktop-wallet.git
cd kryptokrona-desktop-wallet
yarn
yarn start

And look for some clues in Dev tools, that would be great. As soon as someone in the dev team can reproduce the issue, we will obviously debug it but until then our hands are tied!

@Shai0Hulud
Copy link

I assumed that the missing account balance might be outside the visible window, as other informations seem to be outside the visible windows or truncated (like the icon to lock the wallet in bottom left for example). I might be wrong though!

@ClausEspersen
Copy link
Author

ClausEspersen commented May 11, 2021

I think it could be a problem with missing styles for light-mode.
I can find definitions for is-dark in app.global.css, but not is-white.
So that might produce something undefined in the render() in Balance.js where:
const color = darkMode ? 'is-dark' : 'is-white';

@ClausEspersen
Copy link
Author

Not sure why it closed the issue, must have hit the wrong button... Reopening...

@ClausEspersen ClausEspersen reopened this May 11, 2021
@f-r00t
Copy link
Member

f-r00t commented May 11, 2021

I think it could be a problem with missing styles for light-mode.
I can find definitions for is-dark in app.global.css, but not is-white.
So that might produce something undefined in the render() in Balance.js where:
const color = darkMode ? 'is-dark' : 'is-white';

Well, that is the old dark/light mode solution, which we are currently not using. Instead we are using the CSS method with prefers-color-scheme, that automatically detects what you have set in your OS settings.

MAYBE there is some old setting that is forcing the is-dark theme on your machine, causing the new and the old styles to clash somehow.

You can go into your File explorer and enter:
%USERPROFILE%.protonwallet

To go to the wallets settings folder.

Simply remove all of the contents and start the wallet again.

Unfortunately, I cannot get the error to reproduce by changing the settings to something incorrect, but it's worth a shot.

@ClausEspersen
Copy link
Author

I renamed the config.json file to spot any changes:
In the new file it says:
"displayCurrency": "XKR",
while it in the old says:
"displayCurrency": "TRTL",

It works now with XKR, and the error is there again, changing it to TRTL.
How, when, why it is/was changed to "TRTL" I donno.. But maybe you can reproduce it, and ignore/hardcode that property. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants