Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm functionnal for Rancher with cloudconfig in a secret #6785

Open
etchevef opened this issue Apr 30, 2024 · 3 comments
Open

Helm functionnal for Rancher with cloudconfig in a secret #6785

etchevef opened this issue Apr 30, 2024 · 3 comments
Labels
area/cluster-autoscaler kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@etchevef
Copy link

Which component are you using?:

cluster-autoscaler, its Helm charts and the Rancher Cloud Provider.

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

The cluster-autoscaler binary is functionnal with rancher, the Helm charts should permit to deploy a similarly functionnal cluster-autoscaler deployment using the Rancher cloud provider, even if not officially supported.

Describe the solution you'd like.:

I want helm parameters corresponding to the values from the rancher cloudconfig, so that I can have a functionnal deployment when chosing the rancher cloud provider.
The corresponding cloudconfig file should be added as a kubernetes secret to be mounted as a volume in the cluster-autoscaler pod.

Describe any alternative solutions you've considered.:

There is a cloudConfigPath parameter already there to mount the cloudConfig from a file on the nodes, but that doesn't feel right and more importantly I don't see how that would work in rancher without also meddling with rancher's node drivers.

Additional context.:

I have implemented this feature for me, hopefuly I'll be linking a pull request to this issue shortly.

I've added a parameter "cloudConfigMethod" that defaults to working with the path as it currently does, but can be switched to "Secret" to use my new parameters and generate the cloudconfig in a secret. My secret will only be populated if cloud provider is rancher though.

@etchevef etchevef added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 30, 2024
@etchevef
Copy link
Author

etchevef commented Apr 30, 2024

My corresponding PR, not sure how to correctly link issue and PR (If I should do that at all ?)

#6786

@adrianmoisey
Copy link
Member

/area cluster-autoscaler

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants