Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude some namespaces from VPA webhook #6232

Closed
adrianmoisey opened this issue Oct 30, 2023 · 7 comments · Fixed by #6788
Closed

Exclude some namespaces from VPA webhook #6232

adrianmoisey opened this issue Oct 30, 2023 · 7 comments · Fixed by #6788
Assignees
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.

Comments

@adrianmoisey
Copy link
Member

adrianmoisey commented Oct 30, 2023

Which component are you using?:

vertical-pod-autoscaler - admission-controller

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
The source of this feature request is https://cloud.google.com/kubernetes-engine/docs/how-to/optimize-webhooks#unsafe-webhooks

GKE displays a warning for webhooks that intercept resources in the kube-system namespace.

This warning seems sane to me.

Describe the solution you'd like.:

Ability to ignore some namespaces for the vertical-pod-autoscaler admission-controller webhook.

Describe any alternative solutions you've considered.:

N/A

Additional context.:

N/A

@adrianmoisey adrianmoisey added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 30, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2024
@adrianmoisey
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2024
@voelzmo
Copy link
Contributor

voelzmo commented Feb 16, 2024

will be fixed by: #6428

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 16, 2024
@adrianmoisey
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 16, 2024
@adrianmoisey
Copy link
Member Author

/area vertical-pod-autoscaler

@adrianmoisey
Copy link
Member Author

/assign @adrianmoisey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants