-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add relabelings config to ServiceMonitor resource #6780
Conversation
Welcome @thefirstofthe300! |
Hi @thefirstofthe300. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e0f6c62
to
7ad4eac
Compare
7e0268c
to
9a6a95d
Compare
/ok-to-test |
/lgtm Thanks @thefirstofthe300 |
@gjtempleton @mwielgus Would you PTAL? |
Hi @thefirstofthe300, Please address the failed test, which is required to pass to merge the PR. |
Here is the
so you need to bump the chart version. |
To update the README.md file, you have to update the README.md.gotmpl file and values.yaml(for values section) and then the pre-commit hooks update the README.md file. JFYI: you have to install Pre-commit hooks before working in the Charts. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@thefirstofthe300, please resolve the merge conflict. |
671b2dc
to
5593f98
Compare
@gjtempleton @Shubham82 @jackfrancis Can I please get an approval here? It's very frustrating to have what I judge to be a very simple PR languish in approval purgatory for five months. I appreciate Jack and Shubham taking the time to LGTM my PR, but not being able to merge despite those reviews is very frustrating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@thefirstofthe300 fair criticism, I'll work to start reinforcing the helm chart (tests, auditing of features) to enable additional approvers in the near future /assign @gjtempleton |
It looks good to me. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, jackfrancis, thefirstofthe300 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Prometheus service discovery meta-labels
__meta_kubernetes_*
labels are not necessarily still attached to a metric when the metric_relabel_configs step is reached. Consequently, it is not possible to configure a label on pod as a metric tag using the chart solely. Adding therelabelings
value to the ServiceMonitor will allow this use case.Special notes for your reviewer:
Does this PR introduce a user-facing change?