Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --enable-provisioning-requests flag #6826

Conversation

yaroslava-serdiuk
Copy link
Contributor

What type of PR is this?

/kind feature

Fixes #6814

Check-capacity was tested manually. The following scenarious were tested:

  • 1 ProvReq, cluster doesn’t have capacity, verify Provisioned=False
  • 1 ProvReq, cluster has capacity which is used by real pods, verify Provisioned=False
  • 1 ProvReq, cluster has capacity, verify Provisioned=True
  • 1 ProvReq, multiple pod templates, only 1 pod template could fit, verify Provisioned=False
  • 2 ProvReqs, each ProvReq could fit, but not both of them. Verify only 1 ProvReq has Provisioned=True, when BookingExpired=True, second ProvReq has Provisioned=True.

/assign @MaciekPytel

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/cluster-autoscaler labels May 14, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2024
@yaroslava-serdiuk
Copy link
Contributor Author

/assign @towca

@MaciekPytel
Copy link
Contributor

/lgtm
/approve

We've discussed with Karpenter team and agreed to allow an opt-in beta in CA 1.30.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel, yaroslava-serdiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit a304cf0 into kubernetes:cluster-autoscaler-release-1.30 May 16, 2024
6 checks passed
BigDarkClown pushed a commit to BigDarkClown/autoscaler that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants