Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cgroup v1 support into maintenance mode #4569

Open
8 tasks done
harche opened this issue Apr 4, 2024 · 30 comments
Open
8 tasks done

Move cgroup v1 support into maintenance mode #4569

harche opened this issue Apr 4, 2024 · 30 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team

Comments

@harche
Copy link
Contributor

harche commented Apr 4, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 4, 2024
@harche
Copy link
Contributor Author

harche commented Apr 4, 2024

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 4, 2024
@harche
Copy link
Contributor Author

harche commented Apr 4, 2024

/assign

@SergeyKanzhelev SergeyKanzhelev changed the title Deprecate support for cgroup v1 Moving cgroup v1 support into maintenance mode Apr 16, 2024
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Apr 16, 2024

I updated the name of a KEP (this issue title) as per our decision: #4572 (comment).

@harche can you please update it in kep.yaml as well?

@SergeyKanzhelev SergeyKanzhelev changed the title Moving cgroup v1 support into maintenance mode Move cgroup v1 support into maintenance mode Apr 17, 2024
@SergeyKanzhelev
Copy link
Member

/label lead-opted-in
/milestone v1.31

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 23, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 23, 2024
@tjons
Copy link
Contributor

tjons commented Jun 5, 2024

Hello @harche 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage stable for 1.31 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: { 1.31 }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@sreeram-venkitesh
Copy link
Member

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 5, 2024
@harche
Copy link
Contributor Author

harche commented Jun 5, 2024

@sreeram-venkitesh this feature is going straight for GA. There is no alpha or beta stage for this feature.

@sreeram-venkitesh
Copy link
Member

@harche Thanks for clarifying! Would you consider this KEP as of type Deprecation? (See Type column in the enhancements tracking board) Does maintenance mode entail that the feature/KEP is planned to be deprecated? Please also update the issue description.

/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jun 5, 2024
@harche
Copy link
Contributor Author

harche commented Jun 5, 2024

Thanks for clarifying! Would you consider this KEP as of type Deprecation?

This KEP is not going to deprecate cgroup v1 support, hence we would not like to classify it as deprecation.

@sreeram-venkitesh
Copy link
Member

Thanks for the quick update!

@hacktivist123
Copy link

Hello @harche 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

@harche
Copy link
Contributor Author

harche commented Jun 12, 2024

Hello @harche 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

kubernetes/website#46801

@rashansmith
Copy link

Hi @harche,

👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
@rashansmith
Copy link

Hey @harche, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

@harche
Copy link
Contributor Author

harche commented Jul 2, 2024

Hey @harche, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

@rashansmith thanks for reaching out. I have created a placeholder PR for the blog post - kubernetes/website#47069

@a-mccarthy
Copy link

Thanks for clarifying! Would you consider this KEP as of type Deprecation?

This KEP is not going to deprecate cgroup v1 support, hence we would not like to classify it as deprecation.

@harche Hi there 👋 I'm Abbie the release comms lead. Just wanted to double check, should this KEP be included in our deprecations and removals blog for 1.31? I see that we aren't classifying this as a deprecation, but do you think its worth highlight to users in the same way? thanks!

@tjons
Copy link
Contributor

tjons commented Jul 8, 2024

Hi @harche - 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@tjons
Copy link
Contributor

tjons commented Jul 18, 2024

@harche could you add kubernetes/kubernetes#126031 to the issue description?

@harche
Copy link
Contributor Author

harche commented Jul 18, 2024

@harche could you add kubernetes/kubernetes#126031 to the issue description?

Done, thanks.

@kannon92
Copy link
Contributor

/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Jul 23, 2024
@sreeram-venkitesh
Copy link
Member

@harche @kannon92 Looks like all the PRs linked in #4569 (comment) are merged. Are we good for code freeze? Are there any other PRs that needs to be merged for this KEP? Thanks!

@harche
Copy link
Contributor Author

harche commented Jul 23, 2024

/stage alpha

@kannon92 this is going straight for stable.

@harche
Copy link
Contributor Author

harche commented Jul 23, 2024

@harche @kannon92 Looks like all the PRs linked in #4569 (comment) are merged. Are we good for code freeze? Are there any other PRs that needs to be merged for this KEP? Thanks!

All the PRs in kubernetes/kubernetes are merged, the documentation PRs (kubernetes/website) are still getting reviewed.

@kannon92
Copy link
Contributor

/stage alpha

@kannon92 this is going straight for stable.

Oh.

Can you update the description then?

I see that they are added to alpha so I figured it was a mistake to have it labeled as stable.

@harche
Copy link
Contributor Author

harche commented Jul 23, 2024

/stage alpha

@kannon92 this is going straight for stable.

Oh.

Can you update the description then?

I see that they are added to alpha so I figured it was a mistake to have it labeled as stable.

Updated, thanks.

@sreeram-venkitesh
Copy link
Member

All the PRs in kubernetes/kubernetes are merged, the documentation PRs (kubernetes/website) are still getting reviewed.

Thanks @harche! Marking this KEP as tracked for code freeze 🎉

@kannon92
Copy link
Contributor

/stage stable

@tjons
Copy link
Contributor

tjons commented Sep 15, 2024

Hello 👋 1.32 Enhancements Lead here,

I'm closing milestone 1.31 now,
If you have more work on this enhancement to complete in v1.32, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.32. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.31 milestone Sep 15, 2024
@tjons
Copy link
Contributor

tjons commented Sep 16, 2024

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Done
Status: Tracked for Doc Freeze
Development

No branches or pull requests

9 participants