Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate & remove Kubelet RunOnce mode #4580

Closed
5 of 6 tasks
HirazawaUi opened this issue Apr 16, 2024 · 16 comments
Closed
5 of 6 tasks

Deprecate & remove Kubelet RunOnce mode #4580

HirazawaUi opened this issue Apr 16, 2024 · 16 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team

Comments

@HirazawaUi
Copy link
Contributor

HirazawaUi commented Apr 16, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 16, 2024
@HirazawaUi
Copy link
Contributor Author

/sig node
/assign

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 16, 2024
@SergeyKanzhelev
Copy link
Member

/label lead-opted-in
/milestone v1.31

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 23, 2024
@SergeyKanzhelev
Copy link
Member

/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status lead-opted-in Denotes that an issue has been opted in to a release labels May 23, 2024
@ArkaSaha30
Copy link
Member

ArkaSaha30 commented Jun 4, 2024

Hello @HirazawaUi 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024..

This enhancement is targeting stage alpha for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP before the enhancements freeze.

For this KEP, we would need to update the following:

  • Retitle and attach the PR in this KEP description for Alpha
  • Update the KEP status as implementable once reviewed.
  • PR needs to be reviewed and merged within the mentioned timeline.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@sreeram-venkitesh
Copy link
Member

With #4581 merged, we can mark this KEP as tracked for enhancements freeze 🎉

@mbianchidev
Copy link
Member

Hello there @HirazawaUi

👋 from the v1.31 Communications Team!
We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating. Or like in this case a deprecation & removal.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@hacktivist123
Copy link

Hello @HirazawaUi 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
@ArkaSaha30
Copy link
Member

ArkaSaha30 commented Jul 8, 2024

Hey again @HirazawaUi 👋, Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Regarding this enhancement, it appears that there are currently no open pull requests in the k/k repository related to it.

For this KEP, we would need to do the following:

  • Ensure all PRs to the Kubernetes repo related to your enhancement are linked in the above issue description (for tracking purposes).
  • Ensure all PRs are prepared for merging (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

@ArkaSaha30
Copy link
Member

Hey again @HirazawaUi 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in about 2 days, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. A few requirements mentioned in the comment #4580 (comment) still need to be completed:

  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

If you anticipate missing code freeze, you can file an exception request in advance.

@HirazawaUi
Copy link
Contributor Author

@ArkaSaha30 I'm pushing it forward, but we still have some issues that are unresolved.

@ArkaSaha30
Copy link
Member

@ArkaSaha30 I'm pushing it forward, but we still have some issues that are unresolved.

Since we are very close to the Code Freeze_(02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.)_ I would request you to file an exception request if you anticipate it can make it to 1.31.

@sreeram-venkitesh
Copy link
Member

I'm guessing kubernetes/kubernetes#125649 is the only PR that we need to track for this KEP. This PR has got an approval and is waiting for conflicts to be fixed.

@HirazawaUi: Please let us know if there is anything else.

@sreeram-venkitesh
Copy link
Member

Hello @HirazawaUi 👋 v1.31 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.31 milestone. (Your PR kubernetes/kubernetes#125649 has a merge conflict).

If you still wish to progress this enhancement in v1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.31 milestone Jul 24, 2024
@HirazawaUi
Copy link
Contributor Author

/close
@sreeram-venkitesh Thank you for your support, but we will close this issue and will not move forward with it.

@k8s-ci-robot
Copy link
Contributor

@HirazawaUi: Closing this issue.

In response to this:

/close
@sreeram-venkitesh Thank you for your support, but we will close this issue and will not move forward with it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sreeram-venkitesh
Copy link
Member

@HirazawaUi Do we not need this KEP for the deprecation? Should someone else take up this KEP for the next cycle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
No open projects
Status: Removed from Milestone
Development

No branches or pull requests

7 participants