Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend keps/sig-apps/sidecarcontainers.md to reflect kubernetes/kubernetes#52345 #691

Closed
majgis opened this issue Jan 16, 2019 · 8 comments
Closed
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@majgis
Copy link

majgis commented Jan 16, 2019

This issue proposes an amendment to the existing sidecarcontainers KEP:
https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/sidecarcontainers.md

The issue kubernetes/kubernetes#52345 and associated PR were closed in favor of the sidecarcontainers KEP.

Reading through the sidecarcontainers KEP, it is unclear that the concerns outlined in kubernetes/kubernetes#52345 will be addressed, specifically that configuration will allow the initContainer(or pod or sidecar-initContainer) to be restarted when a specific container errors.

I propose that kubernetes/kubernetes#52345 be listed in either the goals or non-goals section of the sidecarcontainers KEP. In the case it is included in goals, further elaboration could be provided in other appropriate sections. In the case it is included in non-goals, a new KEP can be proposed.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 16, 2019
@majgis
Copy link
Author

majgis commented Jan 16, 2019

/sig apps
/sig node

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 16, 2019
@majgis
Copy link
Author

majgis commented Jan 19, 2019

An idea to address kubernetes/kubernetes#52345 would be to allow a new type of initContainer associated with a single container (CIC). This approach would solve the life-cycle problem, ensuring that only the CIC is run prior to restarting the container. The current pod initContainer(s) continues to run only when the pod restarts and the new CIC runs prior to a specific container.

@majgis
Copy link
Author

majgis commented Jan 29, 2019

#753

@Joseph-Irving
Copy link
Member

Hi, this was discussed a few times during the creation of the sidecars KEP and it never seemed to fit in with the problems we were trying to solve nor the solution we were suggesting, it makes a lot more sense, to me at least, to solve this in a separate KEP.

@majgis
Copy link
Author

majgis commented Feb 14, 2019

I agree that a separate KEP makes sense. I will close this issue and open a new one to propose the new KEP.

@majgis majgis closed this as completed Feb 14, 2019
@mtritschler
Copy link

mtritschler commented Mar 1, 2019

@majgis could you post a link to that new KEP or a PR? Thanks

@majgis
Copy link
Author

majgis commented Mar 1, 2019

@mtritschler Thank you for the reminder. I'll make sure that is created this weekend and post the link here.

@majgis
Copy link
Author

majgis commented Mar 4, 2019

#871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

4 participants