Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presubmit checks for stable metrics #1833

Open
CatherineF-dev opened this issue Sep 14, 2022 · 8 comments · Fixed by #1844, #1976 or #1977 · May be fixed by #2294
Open

Presubmit checks for stable metrics #1833

CatherineF-dev opened this issue Sep 14, 2022 · 8 comments · Fixed by #1844, #1976 or #1977 · May be fixed by #2294
Assignees
@CatherineF-dev
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@CatherineF-dev
Copy link
Contributor

CatherineF-dev commented Sep 14, 2022 •
edited

What would you like to be added:
A presubmit to validate stable metrics don't change metric name, add labels or delete labels.

Similar to k8s stable metrics presubmit.

Why is this needed:
Guarantee stable metrics are stable.

Due to lack of presubmit check, some stable metrics are changed. For example,

Describe the solution you'd like

  1. Import k8s metrics stability framework Import k8s metrics stability framework #1844 and Migrate all NewFamilyGenerator to NewFamilyGeneratorWithStability #1976
  2. Presubmit check Check stable metrics aren't changed #1836

Additional context
@CatherineF-dev CatherineF-dev added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 14, 2022
@CatherineF-dev CatherineF-dev mentioned this issue Sep 17, 2022
Closed
@CatherineF-dev CatherineF-dev mentioned this issue Sep 27, 2022
Merged
@CatherineF-dev
Copy link
Contributor Author

/open

@dgrisonnet dgrisonnet reopened this Oct 14, 2022
@CatherineF-dev CatherineF-dev mentioned this issue Feb 6, 2023
Merged
@CatherineF-dev
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Feb 6, 2023
@k8s-ci-robot
Copy link
Contributor

@CatherineF-dev: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 6, 2023
@CatherineF-dev CatherineF-dev mentioned this issue Feb 7, 2023
Merged
@CatherineF-dev
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Feb 7, 2023
@k8s-ci-robot
Copy link
Contributor

@CatherineF-dev: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@logicalhan
Copy link
Member

/triage accepted
/assign @CatherineF-dev

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 9, 2023
@CatherineF-dev CatherineF-dev mentioned this issue Oct 30, 2023
Merged
@CatherineF-dev CatherineF-dev mentioned this issue Dec 6, 2023
Closed
@CatherineF-dev CatherineF-dev linked a pull request Jan 2, 2024 that will close this issue
Open
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 9, 2024
@CatherineF-dev
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CatherineF-dev CatherineF-dev

Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
5 participants
@logicalhan @k8s-ci-robot @dgrisonnet @k8s-triage-robot @CatherineF-dev