Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet token distribution on AWS #2440

Closed
erictune opened this issue Nov 18, 2014 · 10 comments
Closed

Kubelet token distribution on AWS #2440

erictune opened this issue Nov 18, 2014 · 10 comments
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@erictune
Copy link
Member

Make #2387 work for AWS.

Suggested steps:

  1. add the same lines to cluster/aws/templates/create-dynamic-salt-files.sh as Kubelet talks securely to apiserver #2387 added to cluster/gce/templates/create-dynamic-salt-files.sh
  2. change {% if grains.cloud == "gce" %} to {% if grains.cloud in ["gce", "aws"] %} in cluster/saltbase/salt/kube-apiserver/default and cluster/saltbase/salt/kube-apiserver/init.sls
  3. change if provider != "gce" to if provider != "gce" and provider != "aws" { in cmd/e2e/e2e.go
  4. CLOUD_PROVIDER=aws hack/e2e-test.sh
@erictune
Copy link
Member Author

I'd do it but I don't have an AWS account or any experience with AWS provider.

@erictune
Copy link
Member Author

@kelseyhightower @justinsb
This should be pretty straightforward if you've run k8s on AWS before -- and I think you both have.

@goltermann goltermann added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Dec 3, 2014
@bwahn
Copy link

bwahn commented Dec 10, 2014

@erictune I have a AWS acount. Can I test on AWS?

@bwahn
Copy link

bwahn commented Dec 11, 2014

@erictune After testing this issue, I will comment.

@erictune
Copy link
Member Author

I realized that there are actually several separate AWS getting-started guides.
There is docs/getting-started-guides/aws.md which uses kube-up and there is docs/getting-started-guides/coreos.md which includes AWS.

@erictune
Copy link
Member Author

At the same time as doing this work, also change the kube-proxy to set the flag:
--master=http://$APISERVER:7080.

@justinsb
Copy link
Member

For work-coordination: I'm going to start my day today by doing this, at least for AWS/Ubuntu. I'm working in https://github.com/justinsb/kubernetes/tree/fix_aws

@erictune
Copy link
Member Author

Awesome, thank

On Thu, Jan 29, 2015 at 6:41 AM, Justin Santa Barbara <
notifications@github.com> wrote:

For work-coordination: I'm going to start my day today by doing this, at
least for AWS/Ubuntu. I'm working in
https://github.com/justinsb/kubernetes/tree/fix_aws


Reply to this email directly or view it on GitHub
#2440 (comment)
.

@bwahn
Copy link

bwahn commented Feb 5, 2015

Great news~

@davidopp davidopp added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Feb 17, 2015
@roberthbailey roberthbailey added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 3, 2015
@erictune
Copy link
Member Author

looks fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Development

No branches or pull requests

6 participants