Integrate docker with kubelet via CRI #31459

yujuhong · 2016-08-25T19:57:15Z

Meta issue: #28789

This issue tracks the progress of docker integration via CRI.

The initial CRI server-side implementation for docker is in the pkg/kubelet/dockershim package. We chose to let the code remain in the kubelet codebase to help with the migration. It will also not go through grpc/protobuf until the features are completed.

For 1.5, we aim to have a functional docker integration.

Implementation TODOs: #29478
Current integration CI Node E2E builder (#33189): https://k8s-testgrid.appspot.com/google-node#kubelet-cri-gce-e2e
Current integration CI E2E builder (kubernetes/test-infra#712): https://k8s-testgrid.appspot.com/google-gce#gci-gce-cri
Current presubmit builder:

@k8s-bot cri node e2e test this to trigger node e2e test.
@k8s-bot cri e2e test this to trigger e2e test.
@k8s-bot cri test this to trigger both.

Relevant PRs so far: #29700, #29553, #29580
Relevant issues: #29252

The text was updated successfully, but these errors were encountered:

Automatic merge from submit-queue dockershim: use the new Metadata types and add more unit tests Part of #31459

Automatic merge from submit-queue dockershim: add unit tests for sandbox/container status Part of #31459

Automatic merge from submit-queue Fake container exec/logs support for in-process docker CRI integration This is necessary to unblock other work on docker integration, while we are addressing `logs` and `exec` in the meantime. This is part of #31459 and #33189 /cc @kubernetes/sig-node

Random-Liu · 2016-09-30T01:03:00Z

Got the first e2e result: 202 Passed | 12 Failed | 0 Pending | 194 Skipped
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-e2e-gci-gce-cri/1

feiskyer · 2016-09-30T01:16:22Z

Got the first e2e result: 202 Passed | 12 Failed | 0 Pending | 194 Skipped
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-e2e-gci-gce-cri/1

Hmm, initcontainers are already addressed in #33363, port-forwarding is not implemented yet, we could deal it same with exec for docker.

feiskyer · 2016-09-30T03:08:36Z

Claims port-forward for docker.

Update: refer #33810.

Random-Liu · 2016-09-30T04:04:15Z

Claims attach for docker. Attach is also not implemented in kuberuntime yet. I'll verify with my local cluster even though the change is very small. :) Will send a PR soon after I verify it.

PR #33815.

@Random-Liu

Automatic merge from submit-queue Fake docker portfoward for in-process docker CRI integration This is necessary to pass e2e tests for in-process docker CRI integration. This is part of #31459. cc/ @Random-Liu @kubernetes/sig-node

@feiskyer

Automatic merge from submit-queue CRI: Add fake attach support in CRI. For #31459. I've tested in my cluster, it works. @feiskyer @yujuhong

Automatic merge from submit-queue Apply default image tags for all runtimes Move the docker-specific logic up to the ImageManager to allow code sharing among different implementations. Part of #31459 /cc @kubernetes/sig-node

@yujuhong

Automatic merge from submit-queue CRI: Add presubmit CRI validation test. For #31459. This PR adds a new suite for CRI presubmit validation which runs non-flaky, non-serial, non-slow test per-pr. Except this PR, I'll also change the test-infra side. Ideally, after this is done, we should be be able to trigger CRI validation test per-pr with something like `@k8s-bot cri node e2e test this` and `@k8s-bot cri e2e test this`. @yujuhong @feiskyer @yifan-gu @freehan /cc @kubernetes/sig-node

@yujuhong

…chmark Automatic merge from submit-queue CRI: Add serial and benchmark test suite. For #31459. The serial test result will be shown on test-grid. The benchmark test result will be shown [node-perf-dash](http://node-perf-dash.k8s.io/#/builds) This PR also changes the cri validation test to use the same gci image with node e2e instead of the canary image. The docker version is still 1.11.2. @yujuhong @feiskyer @yifan-gu /cc @kubernetes/sig-node

@yujuhong

…rf-dash Automatic merge from submit-queue CRI: Add cri benchmark test in node perf dash. For kubernetes/kubernetes#31459. This depends on kubernetes/test-infra#761 and kubernetes/kubernetes#34141. After this gets merged, I'll restart node perf dash. Then we should be able to monitor benchmark result with cri enabled. @yujuhong @feiskyer /cc @kubernetes/sig-node

Random-Liu · 2016-10-28T04:15:54Z

I run density test to compare operation latency with grpc/non-grpc integration.
Here is the result: https://docs.google.com/spreadsheets/d/1CK-lq2rERkx50-DXl3QUYLtaTNCIZyaQAezEMTnYJc0/edit?usp=sharing

It turns out that the latency increment is acceptable, for example list_container latency is increased by 30%.

However, the memory usage is increased a lot by about 80%:

I'll run some test to analyze the memory usage increment.

@yujuhong @feiskyer
/cc @kubernetes/sig-node

dims · 2016-11-16T15:14:06Z

@yujuhong @Random-Liu This needs to be triaged as a release-blocker or not for 1.5

yujuhong · 2016-11-17T00:40:09Z

We completed all the p0/p1 items. Moving the issue to 1.6 to finish the rest.

redbaron · 2017-02-15T18:15:22Z

is it still planned for 1.6?

yujuhong · 2017-02-15T19:00:49Z

Yes, we just enabled the CRI implementation by default in kubelet last night.

redbaron · 2017-02-15T19:11:21Z

great! does it mean that hostPort feature will work for CNI enabled setups?

yujuhong · 2017-02-15T19:45:52Z

@redbaron unfortunately no. It works for kubenet, but not for CNI. The effort of pushing host port logic down to CNI is tracked in #31307

yujuhong · 2017-02-15T19:46:23Z

Closing this issue since the only thing left is the CRI validation test, which is tracked separately.

yujuhong added area/kubelet-api sig/node Categorizes an issue or PR as relevant to SIG Node. labels Aug 25, 2016

yujuhong added this to the v1.5 milestone Aug 25, 2016

yujuhong self-assigned this Aug 25, 2016

This was referenced Aug 25, 2016

Integrate Docker with new runtime interface #29252

Closed

Container Runtime Interface/API Planning #28789

Closed

dockershim: use the new Metadata types and add more unit tests #31573

Merged

yujuhong mentioned this issue Sep 1, 2016

dockershim: add unit tests for sandbox/container status #31804

Merged

k8s-github-robot pushed a commit that referenced this issue Sep 12, 2016

Merge pull request #31573 from yujuhong/shim_tests

ee2ae07

Automatic merge from submit-queue dockershim: use the new Metadata types and add more unit tests Part of #31459

k8s-github-robot pushed a commit that referenced this issue Sep 12, 2016

Merge pull request #31804 from yujuhong/shim_test2

d66fde7

Automatic merge from submit-queue dockershim: add unit tests for sandbox/container status Part of #31459

yujuhong mentioned this issue Sep 14, 2016

CRI: kuberuntime can't handle docker api version #32741

Closed

This was referenced Sep 21, 2016

Apply default image tags for all runtimes #33233

Merged

Fake container exec/logs support for in-process docker CRI integration #33301

Merged

This was referenced Sep 26, 2016

CRI implemention in kubelet (with in-process docker integration) #29478

Closed

Make kubelet-cri-gce-e2e-ci/gci-gce-cri green #33189

Closed

Random-Liu mentioned this issue Sep 29, 2016

CRI: Add e2e cri validation test. kubernetes/test-infra#712

Merged

feiskyer mentioned this issue Sep 30, 2016

Fake docker portfoward for in-process docker CRI integration #33810

Merged

Random-Liu mentioned this issue Sep 30, 2016

CRI: Add fake attach support in CRI. #33815

Merged

k8s-github-robot pushed a commit that referenced this issue Sep 30, 2016

Merge pull request #33815 from Random-Liu/add-cri-fake-attach

918e99e

Automatic merge from submit-queue CRI: Add fake attach support in CRI. For #31459. I've tested in my cluster, it works. @feiskyer @yujuhong

yujuhong mentioned this issue Oct 4, 2016

Proposal: Add a rktlet proposal in upstream. #33704

Merged

This was referenced Oct 5, 2016

CRI: Add presubmit CRI validation test. #34068

Merged

CRI: Add cri e2e and node e2e presubmit test. kubernetes/test-infra#755

Merged

CRI: Add serial and benchmark test suite. #34141

Merged

This was referenced Oct 5, 2016

CRI: Add cluster/node e2e serial and node benchmark cri validation test. kubernetes/test-infra#761

Merged

CRI: Add cri benchmark test in node perf dash. kubernetes-retired/contrib#1841

Merged

Random-Liu mentioned this issue Oct 25, 2016

CRI: Add CRI e2e soaking test. kubernetes/test-infra#922

Merged

yujuhong modified the milestones: v1.6, v1.5 Nov 17, 2016

yujuhong closed this as completed Feb 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate docker with kubelet via CRI #31459

Integrate docker with kubelet via CRI #31459

yujuhong commented Aug 25, 2016 •

edited

Random-Liu commented Sep 30, 2016 •

edited

feiskyer commented Sep 30, 2016

feiskyer commented Sep 30, 2016 •

edited

Random-Liu commented Sep 30, 2016 •

edited

Random-Liu commented Oct 28, 2016 •

edited

dims commented Nov 16, 2016

yujuhong commented Nov 17, 2016

redbaron commented Feb 15, 2017

yujuhong commented Feb 15, 2017

redbaron commented Feb 15, 2017

yujuhong commented Feb 15, 2017

yujuhong commented Feb 15, 2017

Integrate docker with kubelet via CRI #31459

Integrate docker with kubelet via CRI #31459

Comments

yujuhong commented Aug 25, 2016 • edited

Random-Liu commented Sep 30, 2016 • edited

feiskyer commented Sep 30, 2016

feiskyer commented Sep 30, 2016 • edited

Random-Liu commented Sep 30, 2016 • edited

Random-Liu commented Oct 28, 2016 • edited

dims commented Nov 16, 2016

yujuhong commented Nov 17, 2016

redbaron commented Feb 15, 2017

yujuhong commented Feb 15, 2017

redbaron commented Feb 15, 2017

yujuhong commented Feb 15, 2017

yujuhong commented Feb 15, 2017

yujuhong commented Aug 25, 2016 •

edited

Random-Liu commented Sep 30, 2016 •

edited

feiskyer commented Sep 30, 2016 •

edited

Random-Liu commented Sep 30, 2016 •

edited

Random-Liu commented Oct 28, 2016 •

edited