Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up parameters in e2e tests #6699

Closed
justinsb opened this issue Apr 10, 2015 · 3 comments
Closed

Clean up parameters in e2e tests #6699

justinsb opened this issue Apr 10, 2015 · 3 comments
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@justinsb
Copy link
Member

#5138 now uses the gce_zone parameter as the zone for AWS also.

We should figure out which parameters have genuine meaning across clouds and can be shared, and rename them (gce_zone -> cloud_zone or just zone) This will likely break the scripts etc that set these flags though, so we have to be careful.

@lavalamp lavalamp added team/cluster priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Apr 10, 2015
@lavalamp
Copy link
Member

Yeah, it definitely feels pretty weird to use gce_zone both places.

@0xmichalis 0xmichalis added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed team/cluster (deprecated - do not use) labels Mar 20, 2017
@fejta
Copy link
Contributor

fejta commented Jun 2, 2017

/close

@k8s-ci-robot
Copy link
Contributor

@fejta: you can't close an issue unless you authored it or you are assigned to it.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta fejta closed this as completed Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

5 participants