Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load test shouldn't delete configmaps and secrets for running pods #1575

Open
mborsz opened this issue Nov 17, 2020 · 6 comments
Open

Load test shouldn't delete configmaps and secrets for running pods #1575

mborsz opened this issue Nov 17, 2020 · 6 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@mborsz
Copy link
Member

mborsz commented Nov 17, 2020

From kubernetes/kubernetes#96038 (comment)

It looks like we do delete deployment, configmap and secret at roughly the same time. This is incorrect in general, as there can be large delay between deployment deletion and pod deletion (e.g. if we make our tests even faster and the kube-controller-manager has a O(minutes) backlog of pods to be deleted).

During that delay, the running pod should be able to restart for whatever reason (e.g. kernel panic, machine failure).

We should modify our test to delete configmaps and secrets after we waited for all pods to be deleted.

@mborsz mborsz added the kind/bug Categorizes issue or PR as related to a bug. label Nov 17, 2020
@wojtek-t
Copy link
Member

I don't think that's really a bug per-se. Yes - technically we can delete secrets/configmaps before deleting a pod, but that's supported usecase in k8s.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2021
@wojtek-t
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 24, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2021
@wojtek-t
Copy link
Member

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 26, 2021
@jkaniuk
Copy link
Contributor

jkaniuk commented Jun 7, 2021

/assign @mborsz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants