-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load test shouldn't delete configmaps and secrets for running pods #1575
Comments
I don't think that's really a bug per-se. Yes - technically we can delete secrets/configmaps before deleting a pod, but that's supported usecase in k8s. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
/assign @mborsz |
From kubernetes/kubernetes#96038 (comment)
It looks like we do delete deployment, configmap and secret at roughly the same time. This is incorrect in general, as there can be large delay between deployment deletion and pod deletion (e.g. if we make our tests even faster and the kube-controller-manager has a O(minutes) backlog of pods to be deleted).
During that delay, the running pod should be able to restart for whatever reason (e.g. kernel panic, machine failure).
We should modify our test to delete configmaps and secrets after we waited for all pods to be deleted.
The text was updated successfully, but these errors were encountered: