Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use persist connection ? #34

Open
bdfy opened this issue Sep 24, 2014 · 7 comments
Open

How to use persist connection ? #34

bdfy opened this issue Sep 24, 2014 · 7 comments

Comments

@bdfy
Copy link

bdfy commented Sep 24, 2014

Example ( use persist connection ) from README.markdown not work for last sphinx with default configure. After start example script freeze and it is all ...

@kurokikaze
Copy link
Owner

I'll look into it.

@aescarcha
Copy link

This is 4 years old, I guess the project is not being supported any longer, but I have the same issue... tested on Node 6, 8, 10 and sphinx 2.0.4

@kurokikaze
Copy link
Owner

Fixed in limestone@0.2.0, check it out.

@kurokikaze
Copy link
Owner

Added test connection script to tests, tested with Sphinx 3.1.1-dev

@aescarcha
Copy link

Thanks for the fixes @kurokikaze , it looks like the connection is persisted. I thought this would not be fixed so I forked your repository and published it to NPM to use it myself, it's here. I've also made some changes:

  • Exposed _connected and _queue
  • Filters are cloned instead of modified (it added exclude: 0)
  • New persConnect method which returns a promise (I like them better than callbacks)

If you can add that to this repository I'd gladly abandon mine :)

@kurokikaze
Copy link
Owner

Solid work, @aescarcha! I'll check if I can make pull request from your repo kinda automatically.

@aescarcha
Copy link

Thanks @kurokikaze that'd be great! I added another commit, I'm spawning multiple processes each opening multiple connections... at some point Sphinx just closes them, this commit executes every queued job callback with error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants