Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paging option when fetching builds #9

Open
doublejosh opened this issue Jan 22, 2015 · 0 comments
Open

Add paging option when fetching builds #9

doublejosh opened this issue Jan 22, 2015 · 0 comments

Comments

@doublejosh
Copy link

Problem:

For example, when looking for builds by branch you can get no results when there are indeed builds beyond the "first page" of API results...

$client->fetchRepository($repo);
$client->getBuilds()->findBy(array('branch' => $branch));
$build = $builds->first();

Recommendations:

This would allow setting an optional page limit when populating repository data...

public function fetchRepository($slug, $pageLimit = 1)

This would make it a property of the client...

private $pageLimit = 1;
public function setPageLimit($limit)
{
  $this->pageLimit = $limit;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant