Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring getrawmempool up to date #22

Open
roylee17 opened this issue Feb 14, 2022 · 1 comment
Open

Bring getrawmempool up to date #22

roylee17 opened this issue Feb 14, 2022 · 1 comment
Assignees
Labels
mempool rpc RPC related issues

Comments

@roylee17
Copy link
Collaborator

roylee17 commented Feb 14, 2022

ancestor* descendant* attributes are currently mocked with the transaction itself, not from the actual ancestors/descendants.

$ lbrycrd-cli getrawmempool true > lbrycrd-getrawmempool.json

 "016c84d9bf2d1d6e134b513fc03878847ae2a8fe310aea0a399d8518202ddefa": {
    "fees": {
      "base": 0.00114100,
      "modified": 0.00114100,
      "ancestor": 0.00114100,
      "descendant": 0.00114100
    },
    "size": 2259,
    "fee": 0.00114100,
    "modifiedfee": 0.00114100,
    "time": 1644594445,
    "height": 1110043,
    "descendantcount": 1,
    "descendantsize": 2259,
    "descendantfees": 114100,
    "ancestorcount": 1,
    "ancestorsize": 2259,
    "ancestorfees": 114100,
    "wtxid": "016c84d9bf2d1d6e134b513fc03878847ae2a8fe310aea0a399d8518202ddefa",
    "depends": [
    ],
    "spentby": [
    ]
  },
...
$  lbcctl getrawmempool true > lbcd-getrawmempool.json

  "016c84d9bf2d1d6e134b513fc03878847ae2a8fe310aea0a399d8518202ddefa": {
    "size": 2259,
    "vsize": 2259,
    "weight": 9036,
    "fee": 0.001141,
    "time": 1644594446,
    "height": 1110043,
    "startingpriority": 55887613.765151516,
    "currentpriority": 55892328.428030305,
    "depends": []
  },
...
@roylee17 roylee17 self-assigned this Feb 14, 2022
@roylee17
Copy link
Collaborator Author

roylee17 commented Jun 4, 2022

Still have some fields to be populated in RawMempoolVerbose:

https://github.com/lbryio/lbcd/blob/master/mempool/mempool.go#L1510-L1545

@roylee17 roylee17 added the rpc RPC related issues label Jun 11, 2022
@roylee17 roylee17 changed the title getrawmempool compatibility with lbrycrd Bring getrawmempool up to date Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mempool rpc RPC related issues
Projects
None yet
Development

No branches or pull requests

1 participant