Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEMCACHED_CALLBACK_PREFIX_KEY renaming breaks build on older libmemcached versions #120

Open
ketralnis opened this issue Apr 16, 2013 · 5 comments

Comments

@ketralnis
Copy link
Contributor

At some point MEMCACHED_CALLBACK_PREFIX_KEY was renamed to MEMCACHED_CALLBACK_NAMESPACE, but libmemcached in 0.44 won't compile with that name. Should this be named conditionally? Or maybe the renaming can be smoothed on the pylibmc side for consistency

~/src/pylibmc (master)$ python ./setup.py build
running build
running build_py
running build_ext
building '_pylibmc' extension
gcc -fno-strict-aliasing -arch x86_64 -g -Os -pipe -no-cpp-precomp -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -DUSE_ZLIB -I/usr/local/include/python2.7 -c src/_pylibmcmodule.c -o build/temp.macosx-10.4-x86_64-2.7/src/_pylibmcmodule.o -fno-strict-aliasing
In file included from src/_pylibmcmodule.c:34:
src/_pylibmcmodule.h:227: error: ‘MEMCACHED_CALLBACK_NAMESPACE’ undeclared here (not in a function)
src/_pylibmcmodule.c: In function ‘PylibMC_Client_touch’:
src/_pylibmcmodule.c:1074: warning: implicit declaration of function ‘memcached_touch’
error: command 'gcc' failed with exit status 1
@lericson
Copy link
Owner

Right, I'm partly inclined to bump the requirements to libmemcached 1.0.0 instead. I will merge a fix if you make one. Do you actually still use 0.44?

@ketralnis
Copy link
Contributor Author

I folded this into the PR I did for compress_level, but it can be cherry-picked off

@ketralnis
Copy link
Contributor Author

I do actually still use 0.44, yeah :(

@lericson
Copy link
Owner

How do you get the 0.44 source code, at some museum? ;-) Joking aside, I'm swamped at the moment so will merge later.

@spladug
Copy link
Contributor

spladug commented Jun 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants