Enable zlib compression with Memcached check and set

[YPCrumble]

I was trying to enable zlib compression with memcached check-and-set and it appears that this is functionality that hasn't yet been built out:

pylibmc/src/_pylibmcmodule.c

Lines 1041 to 1043 in 78138d3

	/* TODO: because it's RunSetCommand that does the zlib
	compression, cas can't currently use compressed values. */
	success = _PylibMC_SerializeValue(self, key, NULL, value, time, &mset);

I'm not an expert in C but would be happy to try to create a PR if it would be welcomed and useful!

[lericson]

That seems to be the case! There really shouldn’t be two code paths for cas and non-cas sets, so if you want to fix this, do it right!- LudvigOn 4 Jan 2023, at 21:03, YPCrumble ***@***.***> wrote: I was trying to enable zlib compression with memcached check-and-set and it appears that this is functionality that hasn't yet been built out (see https://github.com/lericson/pylibmc/blob/78138d33c4156111294269a2a8f0cfcc66ac5c5c/src/_pylibmcmodule.c#L1041). I'm not an expert in C but would be happy to try to create a PR if it would be welcomed and useful! —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>