remove colon from pair "user:pass" if has no password #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(closes github issue libwww-perl#13)
ranvis
reviewed
Nov 30, 2018
| if (!defined($new) && !length($user)) { | ||
| $self->userinfo(undef); | ||
| if (!defined($new)) { | ||
| $self->userinfo($user || undef); |
There was a problem hiding this comment.
length() is significant to protect username 0.
There was a problem hiding this comment.
@joenio are you able to address the comment above?
karenetheridge
force-pushed
the
master
branch
from
5dcfddf
to
3a2965a
Compare
Merged
|
Thank you! I've pushed this in a new branch with a fix, so this will close soon. |
theory
added a commit
to sqitchers/sqitch
that referenced
this pull request
May 10, 2023
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. So change the tests to use a regular expression to match such URIs, so that the presence of the colon is optional. Resolves #744.
theory
added a commit
to sqitchers/sqitch
that referenced
this pull request
May 10, 2023
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. libwww-perl/URI-db#23 also changed the DSN of URI::Oracle to specify the database name with `service_name=`. So change the tests to use regular expressions to match such URIs and DSNs, so that the presence of the colon or service name is optional. Resolves #744.
theory
added a commit
to sqitchers/sqitch
that referenced
this pull request
May 10, 2023
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. libwww-perl/URI-db#23 also changed the DSN of URI::Oracle to specify the database name with `service_name=`. So change the tests to use regular expressions to match such URIs and DSNs, so that the presence of the colon or service name is optional. Resolves #744.
theory
added a commit
to sqitchers/sqitch
that referenced
this pull request
May 10, 2023
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. libwww-perl/URI-db#23 also changed the DSN of URI::Oracle to specify the database name with `service_name=`. So change the tests to use regular expressions to match such URIs and DSNs, so that the presence of the colon or service name is optional. Resolves #744.
theory
added a commit
to sqitchers/sqitch
that referenced
this pull request
May 17, 2023
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. libwww-perl/URI-db#23 also changed the DSN of URI::Oracle to specify the database name with `service_name=`. So change the tests to use regular expressions to match such URIs and DSNs, so that the presence of the colon or service name is optional. Resolves #744.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes github issue #13)