Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code from llexec.c and sync with main.c #464

Open
memmerto opened this issue Jan 8, 2023 · 0 comments · May be fixed by #469
Open

Remove unused code from llexec.c and sync with main.c #464

memmerto opened this issue Jan 8, 2023 · 0 comments · May be fixed by #469
Assignees
Labels
Area:Core Issues with the LifeLines core Quality:CodeCleanup Issues related to old / obsolete / dead code.
Milestone

Comments

@memmerto
Copy link
Collaborator

memmerto commented Jan 8, 2023

1) Remove unused ext_codeset variable

Specifically:

  • it sets up ext_codeset from ll_langinfo()
  • doesn't use it anywhere
  • doesn't free it

llexec does go through the normal LL setup which configures the internal codeset (int_codeset) via init_lifelines_global() -> update_db_options() -> update_useropts(). This will set everything up for the internal / system / gedcom / report codesets, that are needed to run reports properly.

2) Add sanity checks for codeset

llexec.c does not have the sanity checks using int_codeset and transl_are_all_conversion_ok() that occur immediately after init_lifelines_postdb() in main.c, and it should.

3) Remove unused platform_init() function

This function exists but has no body and should be removed.

I'm not sure what was originally intended here, but the one thing that is missing is a call to init_arch() which is one place we do platform-ish things, so might as well add a call to that in the appropriate place.

@memmerto memmerto added Area:Core Issues with the LifeLines core Quality:CodeCleanup Issues related to old / obsolete / dead code. labels Jan 8, 2023
@memmerto memmerto changed the title Remove unused codeset variable from llexec Remove unused code from llexec Jan 8, 2023
@memmerto memmerto changed the title Remove unused code from llexec Remove unused code from llexec.c and sync with main.c Jan 8, 2023
@memmerto memmerto modified the milestones: 3.3.0, 3.2.0 Jan 8, 2023
@memmerto memmerto self-assigned this Feb 5, 2023
@memmerto memmerto linked a pull request Feb 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Core Issues with the LifeLines core Quality:CodeCleanup Issues related to old / obsolete / dead code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant