fix for undefined lscache. #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nicator.js wasn't refactored thus whenever readFromCache was called it would hit undefined. Also, the cache property was not actually imported into InjectContext. I also updated the distribution and recompiled it with closure (not too familiar with grunt), which works just fine, in case anyone looking for a quick fix.
|
Oh yea, didn't even touch the tests. pfff... |
|
Thanks. I'll verify this in the morning and get 0.7.1 out. I'll also add a On Thursday, July 3, 2014, Christian notifications@github.com wrote:
--Jakob |
jakobo
added a commit
that referenced
this pull request
Jul 14, 2014
The lscache object was undefined due to the refactoring of the communicator. This change converts the communicator calls to this.env.cache. The tests were updated to ensure travis ci passes. Original author: @chrisamaral Fixes #306 This is a recommended patch for all 0.7.0 users and will result in a 0.7.1 build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lscache was renamed to
cacheinInjectContext.envbutcommunicator.jswasn't refactored thus wheneverreadFromCachewas called it would hit undefined. Besides, the.cacheproperty was not actually imported intoInjectContext. I also updated the distribution and recompiled it with closure (not too familiar with grunt), which works just fine, in case anyone looking for a quick fix.